Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Microsoft.UI.Xaml 2.2.1907xxxxx-prerelease #1896

Closed
DHowett-MSFT opened this issue Jul 9, 2019 · 2 comments · Fixed by #3027
Closed

Move to Microsoft.UI.Xaml 2.2.1907xxxxx-prerelease #1896

DHowett-MSFT opened this issue Jul 9, 2019 · 2 comments · Fixed by #3027
Assignees
@DHowett-MSFT
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal-1910

Comments

@DHowett-MSFT
Copy link
Contributor

This will get us support for TabView's automatic sizing mode.

Blocked by:
@DHowett-MSFT DHowett-MSFT added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Jul 9, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 9, 2019
@DHowett-MSFT
Copy link
Contributor Author

@bitcrazed FYI: we can't switch to the new MUX until the blocking issues are resolved.

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 11, 2019
@DHowett-MSFT DHowett-MSFT self-assigned this Jul 11, 2019
@DHowett-MSFT DHowett-MSFT mentioned this issue Sep 19, 2019
Closed
@bitcrazed bitcrazed added this to the Terminal-1910 milestone Sep 24, 2019
This was referenced Sep 26, 2019
Closed
Closed
Merged
@ghost ghost added the In-PR This issue has a related PR label Oct 2, 2019
This was referenced Oct 6, 2019
Closed
Closed
This was referenced Oct 14, 2019
Closed
Closed
DHowett-MSFT pushed a commit that referenced this issue Oct 15, 2019
@DHowett
Upgrade to Microsoft.UI.Xaml 2.2 (#3027)
df26c67 
* We had to move to the final API:
   * Items -> TabItems
   * Items.VectorChanged -> TabItemsChanged
   * TabClose -> TabCloseRequested
   * TabViewItem.Icon -> TabViewItem.IconSource
* TabRowControl has been converted to a ContentPresenter, which
  simplifies its logic a little bit.
* TerminalPage now differentiates MUX and WUX a little better
* Because of the change from Icon to IconSource in TabViewItem,
  Utils::GetColoredIcon needed to be augmented to support MUX IconSources.
  It was still necessary to use for WUX, so it's been templatized.
* I moved us from WUX SplitButton to MUX SplitButton and brought the
  style in line with the one typically provided by TabView.
* Some of our local controls have had their backgrounds removed so
  they're more amenable to being placed on other surfaces.
* I'm suppressing the TabView's padding.
* I removed a number of apparently dead methods from App.
* I've simplified the dragbar's sizing logic and eventing.
* The winmd harvester needed to be taught to not try to copy winmds for
  framework packages.
* We now only initialize the terminal once we know the size

Closes #1896.
Closes #444.
Closes #857.
Closes #771.
Closes #760.
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 15, 2019
@ghost
Copy link

ghost commented Oct 23, 2019

🎉This issue was addressed in #3027, which has now been successfully released as Windows Terminal Preview v0.6.2951.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett-MSFT DHowett-MSFT

Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal-1910
Development

Successfully merging a pull request may close this issue.

Upgrade to Microsoft.UI.Xaml 2.2 microsoft/terminal
2 participants
@bitcrazed @DHowett-MSFT