-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set environment variable WT_FOLDER_PATH
to the folder path that contains WindowsTerminal.exe
#16295
Comments
Wait, no it doesn't. This is actually so simple. Set that variable for terminal itself. So that we can resolve things relative to ourself. brilliant. I think we were already tracking this in #15379 but I'll motion to use this as the tracking thread instead, since this has a real good idea. Thanks! |
…6949) Basically, title. It'd be a neat idea for portable installs of the Terminal to reference files that are right there in the portable install. This PR adds a `WT_SETTINGS_DIR` var to Terminal's own env block. This allows us to resolve profiles relative to our own settings folder. Closes #16295 (cherry picked from commit 36c81f2) Service-Card-Id: 92352620 Service-Version: 1.20
The implemented solution in #16949:
New Config: Launching the profile: The paths exist because the shell is configured using |
See my edited comment above. |
Thanks! |
Thanks for the quick response and the fix! I looked at the PR and it went back and forth on My only other concern is wrapping the icon path with double quotes causes it to fail. Not sure if that would be an issue if the icon were in a path that contained spaces. |
Description of the new feature/enhancement
Set an environment variable
WT_FOLDER_PATH
to the folder path that containsWindowsTerminal.exe
. This variable should be set when Windows Terminal launches before the profile is launched.This would be useful for users that run Windows Terminal in portable mode so Windows terminal profiles can be configured with paths relative to the folder wher WIndows Terminal is installed as shown below:
The normal user profile is configured as shown below and works perfectly because the
%CMDER_ROOT%
env variable was set dynamically before launching Windows Terminal.The above configuration does not work when launching as Administrator because the
%CMDER_ROOT%
env variable is not set globally on the system nor in the Administator's personal environment variables. it produces the error below:For completeness sake the icon config being complained about in the error above is below:
Proposed technical implementation details (optional)
The text was updated successfully, but these errors were encountered: