Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portable Mode should have a consistent way to refer to the root of the portable install #15379

Closed
carlos-zamora opened this issue May 17, 2023 · 2 comments
Closed

Portable Mode should have a consistent way to refer to the root of the portable install #15379

carlos-zamora opened this issue May 17, 2023 · 2 comments
Labels
Area-Portable portable mode Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Punt Jail 👮

Comments

@carlos-zamora
Copy link
Member

Description of the new feature/enhancement

In order to pass in a portable powershell profile to "commandline", we need a way to refer to the root of the portable install. We got around this issue in "backgroundImage" by using ms-appx:///, however, here, we're just passing the string straight over to PowerShell so it can be resolved there.

Proposed technical implementation details (optional)

It seems like it has to be an environment variable, because that's the only way shells are going to know about it. Perhaps something like %WT_PORTABLE_ROOT%.
@carlos-zamora carlos-zamora added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Area-Portable portable mode labels May 17, 2023
@carlos-zamora carlos-zamora added this to the Terminal v1.19 milestone May 17, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 17, 2023
@carlos-zamora carlos-zamora removed Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 7, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Jun 7, 2023
@zadjii-msft zadjii-msft mentioned this issue Nov 13, 2023
Closed
@zadjii-msft
Copy link
Member

@DHowett, our portable mode czar: Motion to dupe this to #16295?

@carlos-zamora
Copy link
Member Author

@DHowett, our portable mode czar: Motion to dupe this to #16295?

Seconded \dup #16295

@carlos-zamora carlos-zamora closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Portable portable mode Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Punt Jail 👮
Development

No branches or pull requests
2 participants
@carlos-zamora @zadjii-msft