-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with the new sdk #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and updated UI tests (#18) - Used the new layouts library and the screenManager dependencies in build.gradle - Refactored the package name of the SurfaceDuoLayout component in the xml layout - Updated UI tests
…pdated UI tests (#19) * Migrated DualView sample to use the new dual screen SDK version and updated UI tests - Added the new dual screen dependencies in the build.gradle file - Created a DualViewApp class to initialize the dual screen components - Implemented the ScreenInfoListener in both fragments and the activity - Moved the fragment navigation logic into the activity - Refactored MapFragment to use the view model instead of the bundle of parcelable data to prevent multiple instances - Updated UI tests - Refactored magic number from DualView which was used to know when no items are selected
…21) Added integration for DragAndDrop sample with new screen manager SDK
…23) Added integration for Hinge Angle sample with new screen manager SDK
ancirja-m
requested review from
CesarValiente,
bimiron,
CristianVerdes and
soalb-m
December 9, 2020 21:51
CristianVerdes
approved these changes
Dec 9, 2020
CesarValiente
approved these changes
Dec 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks team!
CesarValiente
approved these changes
Dec 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks team!
soalb-m
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.