Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added integration for DragAndDrop sample with new screen manager SDK #21

Merged
merged 2 commits into from
Dec 9, 2020
Merged

Added integration for DragAndDrop sample with new screen manager SDK #21

merged 2 commits into from
Dec 9, 2020

Conversation

ancirja-m
Copy link
Contributor

No description provided.

@ancirja-m ancirja-m changed the base branch from develop to integration-with-new-sdk December 9, 2020 13:45
CesarValiente
CesarValiente approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@CesarValiente CesarValiente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Andrei! Just the build problem has to be fixed.

bimiron
bimiron approved these changes Dec 9, 2020
View reviewed changes
Copy link
Collaborator

@bimiron bimiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

...rc/main/java/com/microsoft/device/display/samples/draganddrop/fragment/FragmentExtensions.kt Outdated Show resolved Hide resolved
@ancirja-m ancirja-m merged commit 38c261e into integration-with-new-sdk Dec 9, 2020
@ancirja-m ancirja-m deleted the ancirja/drag-and-drop-new-sdk branch December 9, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bimiron bimiron bimiron approved these changes

@CesarValiente CesarValiente CesarValiente approved these changes

@soalb-m soalb-m Awaiting requested review from soalb-m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ancirja-m @CesarValiente @bimiron