Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove retry on failed commands #125

Merged
merged 3 commits into from
Sep 26, 2018
Merged

Remove retry on failed commands #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3549054
remove retry for any sfctl failure
Christina-Kang Sep 18, 2018
e2b42e6
add release notes
Christina-Kang Sep 18, 2018
091ab52
Merge branch 'master' of https://github.com/Azure/service-fabric-cli …
Christina-Kang Sep 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Unreleased
----------
- Add upgrade-rollback command for compose deployment (#119)
- Upgrade the knack package dependency to version 0.4.2 (#122)
- Remove retry on failed commands, such as 500 status codes being returned. This allows the proper error message to propogate through (#125)

6.0.1
-----
Expand Down
13 changes: 12 additions & 1 deletion src/sfctl/apiclient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,15 @@ def create(_):
ca_cert = ca_cert_info()
auth = ClientCertAuthentication(cert, ca_cert, no_verify)

return ServiceFabricClientAPIs(auth, base_url=endpoint)
client = ServiceFabricClientAPIs(auth, base_url=endpoint)

# client.config.retry_policy has type msrest.pipeline.ClientRetryPolicy
client.config.retry_policy.total = False
client.config.retry_policy.policy.total = False

# msrest defines ClientRetryPolicy in pipline.py.
# ClientRetryPolicy.__init__ defines values for status_forcelist
# which is passed to urllib3.util.retry.Retry
client.config.retry_policy.policy.status_forcelist = None

return client