Remove retry on failed commands #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samedder
previously approved these changes
Sep 18, 2018
…into disable-all-retries
|
Bypassing code owner review required since approval already granted. Approval overridden by merge from master and fixing linting issues |
rapatchi
added a commit
to rapatchi/service-fabric-cli
that referenced
this pull request
Oct 5, 2018
* Update custom SDK and update API version in paths generation test (microsoft#124) * update custom SDK to include get cluster version API * Update paths generation test to reflect updated required API version in get partition list API * Update knack package to be version 0.4.2 (microsoft#122) update knack package to be 0.4.2 * Remove retry on failed commands (microsoft#125) Remove retry for any sfctl failure - no retry on any HTTP request, regardless of returned error code.
rapatchi
added a commit
to rapatchi/service-fabric-cli
that referenced
this pull request
Oct 9, 2018
* Update custom SDK and update API version in paths generation test (microsoft#124) * update custom SDK to include get cluster version API * Update paths generation test to reflect updated required API version in get partition list API * Update knack package to be version 0.4.2 (microsoft#122) update knack package to be 0.4.2 * Remove retry on failed commands (microsoft#125) Remove retry for any sfctl failure - no retry on any HTTP request, regardless of returned error code.
rapatchi
added a commit
to rapatchi/service-fabric-cli
that referenced
this pull request
Oct 9, 2018
* Update custom SDK and update API version in paths generation test (microsoft#124) * update custom SDK to include get cluster version API * Update paths generation test to reflect updated required API version in get partition list API * Update knack package to be version 0.4.2 (microsoft#122) update knack package to be 0.4.2 * Remove retry on failed commands (microsoft#125) Remove retry for any sfctl failure - no retry on any HTTP request, regardless of returned error code.
rapatchi
added a commit
to rapatchi/service-fabric-cli
that referenced
this pull request
Oct 9, 2018
* Show cluster connection URL (microsoft#103) Add command sfctl cluster show-connection. Command shows the currently connected cluster connection. Nothing is returned is no endpoint is set. * Add command to see the current version (microsoft#104) Use `sfctl --version` to see the current sfctl version * Update README (microsoft#105) update readme * Update versions for 6.0.0 release and update get nodes query (microsoft#113) - Update release notes and versions for 6.0.0 release. - Add parameter to set max results for query "sfctl node list" * Add support for python 3.7 and fix linting issues (microsoft#111) - Add support for python 3.7 - Make fixes where flagged by lint. These fixes are from code from a previous commits, but which were not caught until the latest lint tooling update. * Removed customSDK in preparation for release (microsoft#114) Remove the custom SDK folder in preparation for 6.0.0 release. There are no other changes in this PR. Only the deletion of that folder. * Help text update (microsoft#115) Add some fixes to the documentation. This includes a typo in the main help text about which version this release (6.0.0) should target. * Update release notes (microsoft#116) Update release notes * Add customSDK (microsoft#120) * Add upgrade-rollback for compose deployment (microsoft#119) Add upgrade-rollback command for compose deployment * Update custom SDK and update API version in paths generation test (microsoft#124) * update custom SDK to include get cluster version API * Update paths generation test to reflect updated required API version in get partition list API * Update knack package to be version 0.4.2 (microsoft#122) update knack package to be 0.4.2 * Remove retry on failed commands (microsoft#125) Remove retry for any sfctl failure - no retry on any HTTP request, regardless of returned error code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
Before this change, when users got a 500 error from making a call (such as 'sfctl node list'), or select other 4XX errors, such as timeout, there was a retry behavior invoked which both took longer before an error was returned, and also swallowed any detailed error messages. This change disables all such retry behaviors. Users should manually retry on such failures if applicable.
Verifed: