Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #1469 again #1474

Merged
merged 4 commits into from
Dec 30, 2022
Merged

Add #1469 again #1474

merged 4 commits into from
Dec 30, 2022

Conversation

BryanValverdeU
Copy link
Contributor

Add #1469 again without the position change in ensureTypeInContainer

@BryanValverdeU BryanValverdeU merged commit d5e3520 into master Dec 30, 2022
BryanValverdeU added a commit that referenced this pull request Jan 4, 2023
@BryanValverdeU @juliaroldi
Add #1469 again (#1474)
966709d 
* Revert revert

* Remove position change

* Fix Tests

Co-authored-by: Julia Roldi <[email protected]>
@JiuqingSong JiuqingSong deleted the u/bvalverde/reAdd branch September 8, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaroldi juliaroldi juliaroldi approved these changes

@JiuqingSong JiuqingSong Awaiting requested review from JiuqingSong

@ianeli1 ianeli1 Awaiting requested review from ianeli1

@Andres-CT98 Andres-CT98 Awaiting requested review from Andres-CT98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BryanValverdeU @juliaroldi