Add a check for Experimental Feature DefaultFormatInSpan #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanValverdeU
changed the title
BryanValverdeU
requested review from
ianeli1,
Andres-CT98,
juliaroldi and
JiuqingSong
juliaroldi
approved these changes
Dec 16, 2022
juliaroldi
added a commit
that referenced
this pull request
Dec 20, 2022
…)" This reverts commit ea4ea45.
Merged
BryanValverdeU
added a commit
that referenced
this pull request
Dec 30, 2022
BryanValverdeU
added a commit
that referenced
this pull request
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1380, we introduced adding Format in Span instead of DIV.
We added an Experimental Feature but we did not use it to modify the behavior.
Since we added new enums to the repo we cannot fully revert as it would be a breaking change.
So the fix I propose is to start using the Experimental Feature DefaultFormatInSpan to decide if we want the new behavior to add format to the block div or to the span that is nested in the div.