-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get biggest z index of element #1437
Merged
+64
−2
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
dff98a8
get biggest z index
juliaroldi 0f2ede6
comment
juliaroldi 299a0db
refactor
juliaroldi 96c70eb
refactor
juliaroldi d816f4d
refactor
juliaroldi 576be38
refactor
juliaroldi 8bdb046
refactor
juliaroldi 4ed77a9
refactor
juliaroldi 48ce57c
refactor
juliaroldi af4ad8c
refactor and comments
juliaroldi 1e35263
refactor
juliaroldi fda9a24
refactor
juliaroldi a797160
Merge branch 'master' into u/juliaroldi/z-index
juliaroldi 0714059
Merge branch 'master' into u/juliaroldi/z-index
juliaroldi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
packages/roosterjs-editor-plugins/lib/plugins/ImageEdit/editInfoUtils/getLastZIndex.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import { getTagOfNode } from 'roosterjs-editor-dom'; | ||
|
||
/** | ||
* @internal | ||
* Search through from editor div to it's root for the latest z-index value | ||
* @param editorDiv the editor div element | ||
* @returns the z index value | ||
*/ | ||
export default function getLatestZIndex(editorDiv: HTMLElement) { | ||
let child: HTMLElement | null = editorDiv; | ||
let zIndex = 0; | ||
while (child && getTagOfNode(child) !== 'BODY') { | ||
if (child.style.zIndex) { | ||
zIndex = parseInt(child.style.zIndex); | ||
} | ||
child = child.parentElement; | ||
} | ||
return zIndex; | ||
} |
36 changes: 36 additions & 0 deletions
36
packages/roosterjs-editor-plugins/test/imageEdit/getLastZIndexTest.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import getLatestZIndex from '../../lib/plugins/ImageEdit/editInfoUtils/getLastZIndex'; | ||
|
||
describe('getLatestZIndex', () => { | ||
function runTest(element: HTMLElement, expected: number) { | ||
const result = getLatestZIndex(element); | ||
expect(result).toBe(expected); | ||
} | ||
|
||
it('should return parentNode zIndex', () => { | ||
const div = document.createElement('div'); | ||
div.style.zIndex = '20'; | ||
const span = document.createElement('span'); | ||
span.style.zIndex = '10'; | ||
div.appendChild(span); | ||
runTest(span, 20); | ||
}); | ||
|
||
it('should return child zIndex', () => { | ||
const div = document.createElement('div'); | ||
const span = document.createElement('span'); | ||
span.style.zIndex = '30'; | ||
div.appendChild(span); | ||
runTest(span, 30); | ||
}); | ||
|
||
it('should return middle element zIndex', () => { | ||
const div = document.createElement('div'); | ||
const spanParent = document.createElement('div'); | ||
spanParent.style.zIndex = '30'; | ||
div.appendChild(spanParent); | ||
const span = document.createElement('span'); | ||
span.style.zIndex = '20'; | ||
spanParent.appendChild(span); | ||
runTest(span, 30); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add "@internal" in comment
I need to check why the build tool doesn't fail since "@internal" is required here.