Get biggest z index of element #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaroldi
requested review from
JiuqingSong,
BryanValverdeU,
Andres-CT98 and
ianeli1
and removed request for
JiuqingSong
JiuqingSong
reviewed
Nov 28, 2022
| * @param element the parent element | ||
| * @returns | ||
| */ | ||
| export default function getBiggestZIndex(element: HTMLElement) { |
There was a problem hiding this comment.
This function is now only used by image edit plugin, so let's put it there and no need to export, to reduce the size of dom package
| const parent: HTMLElement | null = child?.parentElement; | ||
| if (parent) { | ||
| const parentZIndex = parent.style?.zIndex ? parseInt(parent.style.zIndex) : 0; | ||
| if (parentZIndex > zIndex) { |
There was a problem hiding this comment.
no, what we need is not the largest z index, but the last z index. e.g.
<body>
<div zIndex = 1>
<div zIndex = 100>
...Although 1 < 100, but since 1 is the last zindex, we use it instead of 100
| this.editor.getDocument().body.appendChild(this.zoomWrapper); | ||
| } | ||
|
|
||
| private getEditorDiv(editor: IEditor) { |
There was a problem hiding this comment.
Let's try to avoid getting editor div directly. Plugin should not know editor DIV at all.
You can use editor.getScrollContainer() as the first element.
JiuqingSong
reviewed
Nov 29, 2022
| @@ -0,0 +1,22 @@ | |||
| import { getTagOfNode } from 'roosterjs-editor-dom'; | |||
|
|
|||
| /** | |||
| */ | ||
| export default function getLatestZIndex(editorDiv: HTMLElement) { | ||
| let child: HTMLElement | null = editorDiv; | ||
| let zIndex = child.style.zIndex ? parseInt(child.style.zIndex) : 0; |
There was a problem hiding this comment.
you can simplify this to something like:
let zIndex = 0;
while (child && getTagOfNode(child) != 'BODY') {
if (child.style.zIndex) {
zIndex = parseInt(child.style.zIndex);
}
child = child.parentElement;
}
JiuqingSong
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
getBiggestZIndexapi that search from an elements to it's root for the biggest z-index value.In ImageEdit use
getBiggestZIndexapi to find the biggest index above the editor and add it plus one to the image wrapper.