chore: enable pnpm mode #2811
Merged
chore: enable pnpm mode #2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
tido64
force-pushed
the
tido/enable-pnpm
branch
3 times, most recently
from
3ae84da
to
519c073
Compare
tido64
force-pushed
the
tido/enable-pnpm
branch
from
519c073
to
449dff8
Compare
This was referenced Nov 9, 2023
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 9, 2023
Summary: In pnpm setups, codegen will fail during build because it cannot find its dependencies. Some of the dependencies it relies on at runtime are currently declared under `devDependencies`. This change moves them to `dependencies`. ## Changelog: [GENERAL] [FIXED] - Fix `react-native/codegen` not being able to resolve dependencies in pnpm setups Pull Request resolved: #41398 Test Plan: We are currently trying to [enable pnpm mode](microsoft/rnx-kit#2811) in rnx-kit and hit this issue. We've patched this package locally and it works. Reviewed By: christophpurrer Differential Revision: D51169116 Pulled By: NickGerleman fbshipit-source-id: 28906a0de412c660d2fc42f62deaf77240d27a58
This was referenced Nov 13, 2023
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 13, 2023
…ps (#41399) Summary: `build_codegen!` currently assumes that `react-native/codegen` gets installed next to `react-native`. In a pnpm setup, it's found under `/~/react-native/node_modules/react-native/codegen` instead. However, as dmytrorykun pointed out, we don't actually need to build it outside of this repository. ## Changelog: [GENERAL] [FIXED] - `react-native/codegen` shouldn't be built unless it's in the repo — fixes `pod install` failures in pnpm setups Pull Request resolved: #41399 Test Plan: We have a patched version of `react-native` working in a pnpm setup here: microsoft/rnx-kit#2811 Reviewed By: dmytrorykun Differential Revision: D51201643 Pulled By: cipolleschi fbshipit-source-id: 53767ae08686a20f03b3b93abcbc7d5383083872
tido64
added a commit
to facebook/react-native
that referenced
this pull request
Nov 13, 2023
…ps (#41399) Summary: `build_codegen!` currently assumes that `react-native/codegen` gets installed next to `react-native`. In a pnpm setup, it's found under `/~/react-native/node_modules/react-native/codegen` instead. However, as dmytrorykun pointed out, we don't actually need to build it outside of this repository. ## Changelog: [GENERAL] [FIXED] - `react-native/codegen` shouldn't be built unless it's in the repo — fixes `pod install` failures in pnpm setups Pull Request resolved: #41399 Test Plan: We have a patched version of `react-native` working in a pnpm setup here: microsoft/rnx-kit#2811 Reviewed By: dmytrorykun Differential Revision: D51201643 Pulled By: cipolleschi fbshipit-source-id: 53767ae08686a20f03b3b93abcbc7d5383083872
This was referenced Nov 13, 2023
Merged
acoates-ms
approved these changes
Nov 15, 2023
huntie
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 27, 2023
…ps (#41399) Summary: `build_codegen!` currently assumes that `react-native/codegen` gets installed next to `react-native`. In a pnpm setup, it's found under `/~/react-native/node_modules/react-native/codegen` instead. However, as dmytrorykun pointed out, we don't actually need to build it outside of this repository. ## Changelog: [GENERAL] [FIXED] - `react-native/codegen` shouldn't be built unless it's in the repo — fixes `pod install` failures in pnpm setups Pull Request resolved: #41399 Test Plan: We have a patched version of `react-native` working in a pnpm setup here: microsoft/rnx-kit#2811 Reviewed By: dmytrorykun Differential Revision: D51201643 Pulled By: cipolleschi fbshipit-source-id: 53767ae08686a20f03b3b93abcbc7d5383083872
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: In pnpm setups, codegen will fail during build because it cannot find its dependencies. Some of the dependencies it relies on at runtime are currently declared under `devDependencies`. This change moves them to `dependencies`. ## Changelog: [GENERAL] [FIXED] - Fix `react-native/codegen` not being able to resolve dependencies in pnpm setups Pull Request resolved: facebook#41398 Test Plan: We are currently trying to [enable pnpm mode](microsoft/rnx-kit#2811) in rnx-kit and hit this issue. We've patched this package locally and it works. Reviewed By: christophpurrer Differential Revision: D51169116 Pulled By: NickGerleman fbshipit-source-id: 28906a0de412c660d2fc42f62deaf77240d27a58
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…ps (facebook#41399) Summary: `build_codegen!` currently assumes that `react-native/codegen` gets installed next to `react-native`. In a pnpm setup, it's found under `/~/react-native/node_modules/react-native/codegen` instead. However, as dmytrorykun pointed out, we don't actually need to build it outside of this repository. ## Changelog: [GENERAL] [FIXED] - `react-native/codegen` shouldn't be built unless it's in the repo — fixes `pod install` failures in pnpm setups Pull Request resolved: facebook#41399 Test Plan: We have a patched version of `react-native` working in a pnpm setup here: microsoft/rnx-kit#2811 Reviewed By: dmytrorykun Differential Revision: D51201643 Pulled By: cipolleschi fbshipit-source-id: 53767ae08686a20f03b3b93abcbc7d5383083872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable pnpm mode.
Resolves #2783.
Upstream fixes
build_codegen!not finding@react-native/codegenin pnpm setups facebook/react-native#41399build_codegen!not finding@react-native/codegenin pnpm setups facebook/react-native#41457build_codegen!not finding@react-native/codegenin pnpm setups facebook/react-native#41456build_codegen!not finding@react-native/codegenin pnpm setups react-native-macos#1984build_codegen!not finding@react-native/codegenin pnpm setups react-native-macos#1983Test plan
CI should pass.