Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implement OS specific mechanism to remove memory lock for plugins #791

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

anubhabMajumdar
Copy link
Contributor

@anubhabMajumdar anubhabMajumdar commented Sep 27, 2024

Description

Add OS specific implementation for removing memory lock on Linux/Windows nodes.

Related Issue

Fixes #790

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

  • Can build/run manually
  • Pipelines

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@matmerr matmerr enabled auto-merge September 27, 2024 23:35
@anubhabMajumdar anubhabMajumdar force-pushed the topic/anmajumdar/remove-memlock branch from 6ebe6f7 to 782ac4e Compare September 30, 2024 18:16
@anubhabMajumdar anubhabMajumdar force-pushed the topic/anmajumdar/remove-memlock branch from 782ac4e to d14f327 Compare September 30, 2024 18:17
@anubhabMajumdar anubhabMajumdar changed the title fix: Remove memory lock OS specific implementation fix: Implement OS specific mechanism to remove memory lock for plugins Sep 30, 2024
@matmerr matmerr added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 5eff4bb Sep 30, 2024
31 checks passed
@matmerr matmerr deleted the topic/anmajumdar/remove-memlock branch September 30, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retina agent crashing on Windows nodes
2 participants