fix: Remove memory lock OS specific implementation

Signed-off-by: Anubhab Majumdar <[email protected]>

cmd/legacy/daemon.go

@@ -25,7 +25,6 @@ import (
 	crmgr "sigs.k8s.io/controller-runtime/pkg/manager"
 	metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
 
-	"github.com/cilium/ebpf/rlimit"
 	"github.com/go-logr/zapr"
 	retinav1alpha1 "github.com/microsoft/retina/crd/api/v1alpha1"
 	"github.com/microsoft/retina/internal/buildinfo"
@@ -134,7 +133,9 @@ func (d *Daemon) Start() error {
 	mainLogger := zl.Named("main").Sugar()
 
 	// Allow the current process to lock memory for eBPF resources.
-	if err = rlimit.RemoveMemlock(); err != nil {
+	// OS specific implementation.
+	// This is a no-op on Windows.
+	if err = d.RemoveMemlock(); err != nil {
 		mainLogger.Fatal("failed to remove memlock", zap.Error(err))
 	}
 

cmd/legacy/daemon_linux.go

@@ -0,0 +1,7 @@
+package legacy
+
+import "github.com/cilium/ebpf/rlimit"
+
+func (d *Daemon) RemoveMemlock() error {
+	return rlimit.RemoveMemlock()
+}

cmd/legacy/daemon_windows.go

@@ -0,0 +1,6 @@
+package legacy
+
+func (d *Daemon) RemoveMemlock() error {
+	// This function is a no-op on Windows.
+	return nil
+}