fix: rewrite Dockerfile to resolve architecture mismatch issues #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
changed the title
nddq
reviewed
Apr 24, 2024
rbtr
force-pushed
the
fix/build-arch
branch
2 times, most recently
from
be8ddc9 to
833f1d5
Compare
This should address the arm/amd64 binary errors in the built image while keeping the Go build stage fast by using the buildplatform and cross-compiling. Signed-off-by: Evan Baker <[email protected]>
rbtr
force-pushed
the
fix/build-arch
branch
2 times, most recently
from
781a128 to
8ded7d1
Compare
Signed-off-by: Evan Baker <[email protected]>
|
Tested by deploying the image from my branch on to a Linux x [x86, arm64] and Windows cluster and verifying that all retina-agents started and plugins loaded without error |
rbtr
added
type/enhancement
|
what was the cause of the segfault? @rbtr |
upgraded the tools image to debian 12 (and installed clang14 there) but the agent image was still using debian 11 distroless. updated that and it resolved |
nddq
approved these changes
Apr 25, 2024
nddq
pushed a commit
that referenced
this pull request
May 6, 2024
# Description This should address the arm/amd64 binary errors in the built image while keeping the Go build stage fast by using the BUILDPLATFORM/TARGETPLATFORM and cross-compiling. It also moves the tools stage from bullseye to bookworm: bookworm has clang-14 available in the package manager and directly installable, so all of the manual downloads are removed, and the explicit installations are cut down significantly. Removes some unnecessary Docker cruft which may have been well-intentioned but isn't useful. ## Related Issue This builds on #260 which fixed #130. ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [x] I have updated the documentation, if necessary. - [x] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed Please add any relevant screenshots or GIFs to showcase the changes made. ## Additional Notes Add any additional notes or context about the pull request here. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. --------- Signed-off-by: Evan Baker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should address the arm/amd64 binary errors in the built image while keeping the Go build stage fast by using the BUILDPLATFORM/TARGETPLATFORM and cross-compiling.
It also moves the tools stage from bullseye to bookworm: bookworm has clang-14 available in the package manager and directly installable, so all of the manual downloads are removed, and the explicit installations are cut down significantly.
Removes some unnecessary Docker cruft which may have been well-intentioned but isn't useful.
Related Issue
This builds on #260 which fixed #130.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.