-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to fork /bin/clang. #130
Comments
The same thing happening to me as well. ` goroutine 16 [running]: Host: ubuntu 22.04.3 |
I can reproduce this with v0.0.1 Arm64 images and top-of-tree main. The reason is because the tools image is missing arm64 libraries, and therefore the |
# Description Add missing libraries required for `clang+llvm` to work in agent. Add the missing libs in tools image. Fixes - #130 # Testing Done 1. Built `amd64` and `arm64` image and deployed them in a K8s cluster with both kind of nodes 2. `agent` pod is up and running in all the nodes Signed-off-by: Anubhab Majumdar <[email protected]>
Fixed the image. Please use commit cf23ecb to build an image for |
hello, i encountered the same problem after recompiling retina controller image locally. Compiler environment
Compiler command: Running environment
retina agent error logs:
and i have confirmed that the /bin/clang file exists in the retina controller image. |
I think I have found the cause of the problem. Some binary files in the amd64 architecture image compiled on the arm64 architecture machine are in arm64 format.
I am guessing there might be a problem in the Dockerfile and I‘d be happy to fix it. Could you please assign this issues to me? |
@wenhuwang I think you are right. We do some Assigned the issue to you, thanks for investigating it! 🙂 |
@rbtr thanks for assigned. According to the documentation https://docs.docker.com/reference/dockerfile/#automatic-platform-args-in-the-global-scope, it can be know:
So i guess |
This sounds reasonable to me. Maybe every occurence of @wenhuwang are you interested in opening the PR to fix this, or should someone else pick it up? |
@rbtr OK, I will submit a PR to fix this issue. |
#260) # Description Fixed the issues of retina-controller startup failure caused by abnormal cross-platform build image dependency package architecture. ## Related Issue fixes #130 ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [ ] I have followed the project's style guidelines. - [ ] I have updated the documentation, if necessary. - [ ] I have added tests, if applicable. # Testing Done Built amd64 and arm64 image and deployed amd64 image in K8s cluster nodes agent pod is up and running in the nodes --------- Signed-off-by: wenhuwang <[email protected]>
# Description This should address the arm/amd64 binary errors in the built image while keeping the Go build stage fast by using the BUILDPLATFORM/TARGETPLATFORM and cross-compiling. It also moves the tools stage from bullseye to bookworm: bookworm has clang-14 available in the package manager and directly installable, so all of the manual downloads are removed, and the explicit installations are cut down significantly. Removes some unnecessary Docker cruft which may have been well-intentioned but isn't useful. ## Related Issue This builds on #260 which fixed #130. ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [x] I have updated the documentation, if necessary. - [x] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed Please add any relevant screenshots or GIFs to showcase the changes made. ## Additional Notes Add any additional notes or context about the pull request here. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. --------- Signed-off-by: Evan Baker <[email protected]>
#260) # Description Fixed the issues of retina-controller startup failure caused by abnormal cross-platform build image dependency package architecture. ## Related Issue fixes #130 ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [ ] I have followed the project's style guidelines. - [ ] I have updated the documentation, if necessary. - [ ] I have added tests, if applicable. # Testing Done Built amd64 and arm64 image and deployed amd64 image in K8s cluster nodes agent pod is up and running in the nodes --------- Signed-off-by: wenhuwang <[email protected]>
# Description This should address the arm/amd64 binary errors in the built image while keeping the Go build stage fast by using the BUILDPLATFORM/TARGETPLATFORM and cross-compiling. It also moves the tools stage from bullseye to bookworm: bookworm has clang-14 available in the package manager and directly installable, so all of the manual downloads are removed, and the explicit installations are cut down significantly. Removes some unnecessary Docker cruft which may have been well-intentioned but isn't useful. ## Related Issue This builds on #260 which fixed #130. ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [x] I have updated the documentation, if necessary. - [x] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed Please add any relevant screenshots or GIFs to showcase the changes made. ## Additional Notes Add any additional notes or context about the pull request here. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. --------- Signed-off-by: Evan Baker <[email protected]>
Describe the bug
While I am setting up retina in K8s infra. I am facing below error.
I am not running any operator. for now I am running only DaemonSet and in configmap I am adding plugins
The text was updated successfully, but these errors were encountered: