Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][Executor] Fix the bug of log_progress #2512

Closed
wants to merge 2 commits into from

Conversation

PeiwenGaoMS
Copy link
Contributor

@PeiwenGaoMS PeiwenGaoMS commented Mar 27, 2024

Description

Fix the bug of log_progress

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this
    page
    .

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

…flow-core (#2503)

# Description

Fix extras dependencies in promptflow-core

# All Promptflow Contribution checklist:
- [x] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [x] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [x] Title of the pull request is clear and informative.
- [x] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [ ] Pull request includes test coverage for the included changes.
@PeiwenGaoMS PeiwenGaoMS requested a review from a team as a code owner March 27, 2024 10:57
@PeiwenGaoMS PeiwenGaoMS changed the title [Internal][Core] Fix extras dependencies [executor-service] in prompt… [Bugfix][Executor] Fix the bug pg log_progress Mar 27, 2024
Copy link

github-actions bot commented Mar 27, 2024

SDK CLI Global Config Test Result main

3 tests   3 ✅  45s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 41353f9.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 27, 2024

promptflow SDK CLI Azure E2E Test Result main

  4 files    4 suites   4m 39s ⏱️
196 tests 176 ✅ 20 💤 0 ❌
784 runs  704 ✅ 80 💤 0 ❌

Results for commit 41353f9.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 27, 2024

Executor Unit Test Result main

729 tests   729 ✅  3m 45s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 41353f9.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 27, 2024

Executor E2E Test Result main

218 tests   216 ✅  5m 52s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 41353f9.

♻️ This comment has been updated with latest results.

@PeiwenGaoMS PeiwenGaoMS changed the title [Bugfix][Executor] Fix the bug pg log_progress [Bugfix][Executor] Fix the bug of log_progress Mar 27, 2024
Copy link

github-actions bot commented Mar 27, 2024

SDK CLI Test Result main

   12 files     12 suites   49m 26s ⏱️
  507 tests   488 ✅ 19 💤 0 ❌
2 028 runs  1 952 ✅ 76 💤 0 ❌

Results for commit 41353f9.

♻️ This comment has been updated with latest results.

# Description

Fixing test_assistant_package_tool_with_conn in CI failure

# All Promptflow Contribution checklist:
- [x] **The pull request does not introduce [breaking changes].**
- [x] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [x] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [ ] Pull request includes test coverage for the included changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
executor The changes related to the execution of the flow promptflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants