Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal][Core] Fix extras dependencies [executor-service] in promptflow-core #2503

Merged
merged 3 commits into from
Mar 27, 2024
Merged

[Internal][Core] Fix extras dependencies [executor-service] in promptflow-core #2503

merged 3 commits into from
Mar 27, 2024

Conversation

PeiwenGaoMS
Copy link
Contributor

@PeiwenGaoMS PeiwenGaoMS commented Mar 27, 2024 •
edited
Loading

Description

Fix extras dependencies in promptflow-core

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@PeiwenGaoMS PeiwenGaoMS requested a review from a team as a code owner March 27, 2024 08:50
brynn-code
brynn-code previously approved these changes Mar 27, 2024
View reviewed changes
thy09
thy09 previously approved these changes Mar 27, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

SDK CLI Global Config Test Result devs/peiwen/fix_extra_dependency

3 tests   3 ✅  48s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 401304e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

promptflow SDK CLI Azure E2E Test Result devs/peiwen/fix_extra_dependency

  4 files    4 suites   4m 32s ⏱️
196 tests 176 ✅ 20 💤 0 ❌
784 runs  704 ✅ 80 💤 0 ❌

Results for commit 401304e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

Executor Unit Test Result devs/peiwen/fix_extra_dependency

729 tests   729 ✅  3m 45s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 401304e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

Executor E2E Test Result devs/peiwen/fix_extra_dependency

218 tests   215 ✅  5m 47s ⏱️
  1 suites    2 💤
  1 files      1 ❌

For more details on these failures, see this check.

Results for commit 401304e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

SDK CLI Test Result devs/peiwen/fix_extra_dependency

   12 files     12 suites   49m 32s ⏱️
  507 tests   488 ✅ 19 💤 0 ❌
2 028 runs  1 952 ✅ 76 💤 0 ❌

Results for commit 401304e.

♻️ This comment has been updated with latest results.

@PeiwenGaoMS PeiwenGaoMS dismissed stale reviews from brynn-code and thy09 via d639353 March 27, 2024 10:18
@PeiwenGaoMS PeiwenGaoMS requested a review from a team as a code owner March 27, 2024 10:18
@github-actions github-actions bot added promptflow executor The changes related to the execution of the flow labels Mar 27, 2024
@PeiwenGaoMS PeiwenGaoMS force-pushed the devs/peiwen/fix_extra_dependency branch from 186fece to 401304e Compare March 27, 2024 10:32
@github-actions github-actions bot removed promptflow executor The changes related to the execution of the flow labels Mar 27, 2024
@brynn-code brynn-code merged commit eb85186 into main Mar 27, 2024
64 of 67 checks passed
@brynn-code brynn-code deleted the devs/peiwen/fix_extra_dependency branch March 27, 2024 10:55
@PeiwenGaoMS PeiwenGaoMS mentioned this pull request Mar 27, 2024
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hhhilulu Hhhilulu Hhhilulu approved these changes

@brynn-code brynn-code brynn-code approved these changes

@thy09 thy09 thy09 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PeiwenGaoMS @thy09 @brynn-code @Hhhilulu