Check for old enums value like "Horizontal Left" with space

CHANGELOG.md

@@ -1,9 +1,12 @@
-# 2.4.1
+## 2.4.2
+* Check old enums with space like "Horizontal left" to maintain backward compatibility
+
+## 2.4.1
 * Packages update
 * Fixed tests with measureUnits
 * Fixed eslint errors
 
-# 2.4.0
+## 2.4.0
 * Update powerbi packages, API to 5.7.0
 * Migrate from tslint to eslint
 * Use new formatting model API

package.json

@@ -1,7 +1,7 @@
 {
   "name": "powerbi-visuals-bulletchart",
   "description": "Bullet chart",
-  "version": "2.4.1.0",
+  "version": "2.4.2.0",
   "author": {
     "name": "Microsoft",
     "email": "[email protected]"

pbiviz.json

@@ -1,10 +1,10 @@
 {
   "visual": {
     "name": "BulletChart",
-    "displayName": "Bullet Chart 2.4.1.0",
+    "displayName": "Bullet Chart 2.4.2.0",
     "guid": "BulletChart1443347686880",
     "visualClassName": "BulletChart",
-    "version": "2.4.1.0",
+    "version": "2.4.2.0",
     "description": "A bullet chart that includes four orientations and a few customization options. Use to feature a single measure against a qualitative range.",
     "supportUrl": "https://community.powerbi.com",
     "gitHubUrl": "https://github.com/Microsoft/powerbi-visuals-bulletchart"

src/visual.ts

@@ -364,6 +364,7 @@ export class BulletChart implements IVisual {
         const categoricalValues: BulletChartColumns<any[]> =
             BulletChartColumns.GET_CATEGORICAL_VALUES(dataView);
 
+        BulletChart.updateOrientation(visualSettings, dataView);
         BulletChart.limitProperties(visualSettings);
         visualSettings = this.SetHighContrastColors(visualSettings, colorHelper);
 
@@ -655,6 +656,26 @@ export class BulletChart implements IVisual {
         return null;
     }
 
+    // Implemented for old enums using space containing keys for example "Horizontal Left" which doesn't exist in current version
+    private static updateOrientation(settings: BulletChartSettingsModel, dataView: DataView): void {
+        let orientationValue: string = "";
+
+        if (settings?.orientation?.orientation.value?.value) {
+            orientationValue = settings.orientation.orientation.value.value.toString();
+        }
+        else if (dataView?.metadata?.objects?.orientation?.orientation) {
+            orientationValue = dataView.metadata.objects?.orientation?.orientation as string;
+        }
+
+        const noSpaceOrientation: string = orientationValue.toString().replace(" ", "");
+
+        if (Object.values(BulletChartOrientation).includes(noSpaceOrientation as BulletChartOrientation)) {
+            settings.orientation.orientation.value = settings.orientation.orientation.items.find(option => option.value.toString() === noSpaceOrientation);
+        } else {
+            settings.orientation.orientation.value = settings.orientation.orientation.items.find(option => option.value.toString() === BulletChartOrientation.HorizontalLeft);
+        }
+    }
+
     private static limitProperties(settings: BulletChartSettingsModel): void {
         if (settings.values.minimumPercent.value > settings.values.maximumPercent.value) {
             settings.values.maximumPercent.value = settings.values.minimumPercent.value;