Check for old enums value like "Horizontal Left" with space #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in backwards compatibility
src/visual.ts
Outdated
| @@ -655,6 +656,26 @@ export class BulletChart implements IVisual { | |||
| return null; | |||
| } | |||
|
|
|||
| // Implemented for old enums using space containing keys for example "Horizontal Left" which doesn't exist in current version | |||
| private static updateOrientation(settings: BulletChartSettingsModel, dataView: DataView): void { | |||
There was a problem hiding this comment.
don't mutate args in a static function
give this function a return type or make it not static
MulyukovAidar
approved these changes
Apr 26, 2024
MulyukovAidar
added a commit
that referenced
this pull request
Jun 14, 2024
* Add keyboard navigation support, update packages (#100) * Migrate from tslint to eslint * Update powerbi packages and API to 5.4.0 * Migrate from puppeteer to playwright * Add BulletChartSettingsModel with new formatting api * Migrate to BulletChartSettingModel * Fix tooltip rendering * Split d3 into submodules * Add settings to sync axis Previously each bar had its own axis, which made it difficult to compare them. * Add settings to show only main axis When enabling "sync axis" bars are resized to the same range, but it still shows axis for each bar. The new toggle "showMainAxis" shows only the first axis. * Add keyboard navigation support * Remove azure-pipelines.yml. Update build.yml to use node 18, 20 * Rename static methods to use snake_case * Remove the line alongside axis colors. When displaying units colors there is unnecessary line with axis color, which makes it harder to read. Remove it for better readability. * Move main axis to bottom when Horizontal orientation is set. Main axis should be at the bottom, instead of at the top. * Move "syncAxis", "showMainAxis" to dedicated card in formatting pane. * Update build.yml to run pipeline on 'dev' branch. Remove .travis.yml * Prettify SyncAxis Card in formatting pane * Add "Visual_Long_Description", "Visual_Short_Description" localization keys * Fix not showing scroll when changing orientation from Vertical to Horizontal and vise versa * Update packages * Set powerbi-visuals-api version in pbiviz.json to 5.7.0 * Remove test which checks the color of the line on axis (the line is removed) * Refactor methods to make them below 100 lines * Remove core-js * Update build.yml to run pipeline on 'certification' branch * Refactor CALCULATE_RANGE_VALUE_BASED_ON_PERCENTAGE method and add tests * Refactor keyboard navigation: focus goes from whole bars instead of bullets * Add OnObject functionality (#102) * Add OnObject for "Category labels" * Add OnObject for axis formatting * Add OnObject for "colors" formatting settings * Enable subselection for "Bullet" rects * Remove repeating "displayName", "displayNameKey" from capabilities.json * Move OnObject references to formatting model * Fix tests checking measureUnits value and color * Update packages and version to 2.4.1.0 * Remove redundant dependency 'coveralls' * Check for old enums value like "Horizontal Left" with space (#110) * Check for old enums value like "Horizontal Left" with space to maintain backwards compatibility * Refactor static methods into instance methods * Fix npm vulnerabilities * Update outdated packages * Update API to 5.9.0 * Sync package-lock.json with package.json * New translations (#114) --------- Co-authored-by: adiletelf <[email protected]> Co-authored-by: pbicvloc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's done to maintain a backwards compatibility