Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable @babel/plugin-syntax-import-attributes all the time #32713

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Sep 19, 2024

Fixes #32659

Test is a copy of

test('should support import assertions', async ({ runInlineTest }) => {
- maybe we should remove the test in esm.spec.ts and run it twice, once with type module and once without?

@dgozman
Copy link
Contributor

dgozman commented Sep 19, 2024

  • maybe we should remove the test in esm.spec.ts and run it twice, once with type module and once without?

Or just move it to babel.spec.

@mxschmitt mxschmitt force-pushed the enable-@babel/plugin-syntax-import-attributes branch from 2bb9fa0 to 0dccf16 Compare September 19, 2024 14:29

This comment has been minimized.

@mxschmitt mxschmitt merged commit 2b2a57a into microsoft:main Sep 19, 2024
29 checks passed
Copy link
Contributor

Test results for "tests 1"

1 flaky ⚠️ [webkit-library] › library/video.spec.ts:189:5 › screencast › should capture static page

35526 passed, 661 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "Support for the experimental syntax 'importAttributes' isn't currently enabled"
2 participants