review feedback

microsoft · Sep 19, 2024 · 2bb9fa0 · 2bb9fa0
1 parent c83ba0c
commit 2bb9fa0
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 37 deletions.
diff --git a/tests/playwright-test/babel.spec.ts b/tests/playwright-test/babel.spec.ts
@@ -151,29 +151,31 @@ test('should not transform external', async ({ runInlineTest }) => {
   expect(result.output).toMatch(/(Cannot use import statement outside a module|require\(\) of ES Module .* not supported.)/);
 });
 
-test('should support import assertions', {
-  annotation: {
-    type: 'issue',
-    description: 'https://github.com/microsoft/playwright/issues/32659'
-  }
-}, async ({ runInlineTest }) => {
-  const result = await runInlineTest({
-    'playwright.config.ts': `
+for (const type of ['module', undefined]) {
+  test(`should support import assertions with type=${type} in the package.json`, {
+    annotation: {
+      type: 'issue',
+      description: 'https://github.com/microsoft/playwright/issues/32659'
+    }
+  }, async ({ runInlineTest }) => {
+    const result = await runInlineTest({
+      'playwright.config.ts': `
       import packageJSON from './package.json' assert { type: 'json' };
       console.log('imported value: ' + packageJSON.foo);
       export default { };
     `,
-    'package.json': JSON.stringify({ foo: 'bar' }),
-    'a.esm.test.ts': `
+      'package.json': JSON.stringify({ foo: 'bar', type }),
+      'a.esm.test.ts': `
       import { test, expect } from '@playwright/test';
 
       test('check project name', ({}, testInfo) => {
         expect(1).toBe(1);
       });
     `
-  });
+    });
 
-  expect(result.exitCode).toBe(0);
-  expect(result.passed).toBe(1);
-  expect(result.stdout).toContain('imported value: bar');
-});
+    expect(result.exitCode).toBe(0);
+    expect(result.passed).toBe(1);
+    expect(result.stdout).toContain('imported value: bar');
+  });
+}
diff --git a/tests/playwright-test/esm.spec.ts b/tests/playwright-test/esm.spec.ts
@@ -35,28 +35,6 @@ test('should load nested as esm when package.json has type module', async ({ run
   expect(result.passed).toBe(1);
 });
 
-test('should support import assertions', async ({ runInlineTest }) => {
-  const result = await runInlineTest({
-    'playwright.config.ts': `
-      import packageJSON from './package.json' assert { type: 'json' };
-      console.log('imported value: ' + packageJSON.foo);
-      export default { };
-    `,
-    'package.json': JSON.stringify({ type: 'module', foo: 'bar' }),
-    'a.esm.test.ts': `
-      import { test, expect } from '@playwright/test';
-
-      test('check project name', ({}, testInfo) => {
-        expect(1).toBe(1);
-      });
-    `
-  });
-
-  expect(result.exitCode).toBe(0);
-  expect(result.passed).toBe(1);
-  expect(result.stdout).toContain('imported value: bar');
-});
-
 test('should support import attributes', async ({ runInlineTest }) => {
   const result = await runInlineTest({
     'playwright.config.ts': `