Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(har): record serverIPAddress for API requests #32660

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Sep 17, 2024

Discovered working on #32658. We're recording the remote server address for browser requests, but not for API requests. This PR adds that for API requests.

@Skn0tt Skn0tt requested a review from yury-s September 17, 2024 17:42
@Skn0tt Skn0tt self-assigned this Sep 17, 2024
@Skn0tt Skn0tt changed the title feat(har): track address for api requests feat(har): track remote server address for api requests Sep 17, 2024
@Skn0tt Skn0tt changed the title feat(har): track remote server address for api requests feat(har): record serverAddress for API requests Sep 17, 2024
@Skn0tt Skn0tt changed the title feat(har): record serverAddress for API requests feat(har): record serverIPAddress for API requests Sep 17, 2024

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › babel.spec.ts:135:5 › should not transform external

35505 passed, 659 skipped
✔️✔️✔️

Merge workflow run.

@Skn0tt Skn0tt merged commit 825df6c into microsoft:main Sep 18, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants