Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(har recorder): ensure we respect minimal mode #32658

Merged
merged 2 commits into from
Sep 17, 2024
Merged

chore(har recorder): ensure we respect minimal mode #32658

merged 2 commits into from
Sep 17, 2024

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Sep 17, 2024 •
edited
Loading

Closes #32653.

Adds some test coverage to ensure we respect minimal mode for API Requests in HAR tracing.

omit setting result
omitCookies added test for it
omitTiming already covered
omitSecurityDetails not recorded yet
omitServerIP we don't record it yet, so no action here. gonna open a separate issue
omitPages not relevant to API requests
omitSizes added test for it
omitScripts not relevant to API requests

@Skn0tt Skn0tt requested a review from dgozman September 17, 2024 17:05
@Skn0tt Skn0tt self-assigned this Sep 17, 2024
@Skn0tt Skn0tt mentioned this pull request Sep 17, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › babel.spec.ts:135:5 › should not transform external

2 flaky ⚠️ [chromium-library] › library/capabilities.spec.ts:141:3 › should not crash on showDirectoryPicker
⚠️ [firefox-page] › page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set

35487 passed, 659 skipped
✔️✔️✔️

Merge workflow run.

@Skn0tt Skn0tt merged commit f1390cc into microsoft:main Sep 17, 2024
28 of 30 checks passed
@Skn0tt Skn0tt mentioned this pull request Sep 17, 2024
Merged
Skn0tt added a commit that referenced this pull request Sep 18, 2024
@Skn0tt
feat(har): record securityDetails for API Requests (#32664)
8a97050 
While working on #32658 I
discovered that we're recording `securityDetails` for browser requests,
but not for API requests. This PR fixes that.
Skn0tt added a commit that referenced this pull request Sep 18, 2024
@Skn0tt
feat(har): record serverIPAddress for API requests (#32660)
825df6c 
Discovered working on
#32658. We're recording the
remote server address for browser requests, but not for API requests.
This PR adds that for API requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees

@Skn0tt Skn0tt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[internal] respect HAR recorder minimal mode for API requests
2 participants
@Skn0tt @dgozman