Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(highlight): highlight Top Layer elements (#30001)" #30800

Merged
merged 1 commit into from
May 14, 2024
Merged

Revert "fix(highlight): highlight Top Layer elements (#30001)" #30800

merged 1 commit into from
May 14, 2024

Conversation

mxschmitt
Copy link
Member

This reverts commit a932222.

Closes #30797 - maybe there is a better way to get the page height? document.documentElement.scrollHeight seems to not work on Firefox.
Relates #30770

@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

1 flaky ⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots

27332 passed, 662 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit b06c1df into microsoft:main May 14, 2024
30 checks passed
@mxschmitt mxschmitt mentioned this pull request May 14, 2024
Closed
github-actions bot added a commit that referenced this pull request May 14, 2024
@github-actions
cherry-pick(#30800): Revert "fix(highlight): highlight Top Layer elem…
87e6b6d 
…ents (#30001)"
mxschmitt pushed a commit that referenced this pull request May 14, 2024
@playwrightmachine @github-actions
cherry-pick(#30800): Revert "fix(highlight): highlight Top Layer elem…
01bf93c 
…ents (#30001)" (#30801)

This PR cherry-picks the following commits:

- b06c1df

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxschmitt @dgozman