Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(highlight): highlight Top Layer elements #30001

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Mar 19, 2024

Depends on #30070
Depends on firefox 125 (around April 16)
Fixes #29878

This comment has been minimized.

@mxschmitt mxschmitt force-pushed the fix/highlight-top-layer branch from 42e625d to 4f651d5 Compare March 23, 2024 14:57

This comment has been minimized.

@mxschmitt mxschmitt force-pushed the fix/highlight-top-layer branch 2 times, most recently from 110ba50 to 24fca1a Compare April 18, 2024 09:21

This comment has been minimized.

@mxschmitt mxschmitt added the CQ1 label Apr 18, 2024

This comment has been minimized.

@mxschmitt mxschmitt marked this pull request as ready for review April 18, 2024 09:58
@mxschmitt mxschmitt force-pushed the fix/highlight-top-layer branch from 24fca1a to 4cc87a3 Compare April 18, 2024 10:37
Copy link
Contributor

Test results for "tests 2"

1 fatal errors, not part of any test
11 failed
❌ [chromium-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [chromium-library] › library/tracing.spec.ts:525:5 › should export trace concurrently to second navigation
❌ [firefox-page] › page/page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position
❌ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
❌ [firefox-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
❌ [webkit-library] › library/capabilities.spec.ts:67:3 › should play video @smoke
❌ [webkit-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [webkit-library] › library/capabilities.spec.ts:133:3 › should not crash on page with mp4 @smoke
❌ [webkit-library] › library/modernizr.spec.ts:82:3 › mobile-safari-14-1
❌ [webkit-library] › library/signals.spec.ts:62:7 › signals › should report browser close signal 2

60 flaky ⚠️ [chromium-library] › library/browsercontext-credentials.spec.ts:55:1 › should work with correct credentials @smoke
⚠️ [chromium-page] › page/page-leaks.spec.ts:153:5 › waitFor should not leak
⚠️ [chromium-library] › library/browsercontext-credentials.spec.ts:55:1 › should work with correct credentials @smoke
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [chromium-page] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:667:7 › cli codegen › should assert navigation
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:88:5 › should work with locator.hover()
⚠️ [chromium-library] › library/trace-viewer.spec.ts:240:1 › should have network requests
⚠️ [firefox-page] › page/page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position
⚠️ [firefox-page] › page/elementhandle-wait-for-element-state.spec.ts:117:3 › should wait for stable position
⚠️ [firefox-page] › page/page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position
⚠️ [firefox-page] › page/page-click.spec.ts:445:3 › should wait for stable position
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
⚠️ [firefox-library] › library/permissions.spec.ts:103:5 › permissions › should trigger permission onchange
⚠️ [firefox-library] › library/video.spec.ts:351:5 › screencast › should capture navigation
⚠️ [firefox-page] › page/page-click.spec.ts:445:3 › should wait for stable position
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:88:5 › should work with locator.hover()
⚠️ [firefox-page] › page/page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position
⚠️ [firefox-page] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [firefox-library] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox-page] › page/page-click-scroll.spec.ts:19:3 › should not hit scroll bar
⚠️ [firefox-page] › page/page-click.spec.ts:445:3 › should wait for stable position
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts
⚠️ [firefox-library] › library/browsercontext-route.spec.ts:287:3 › should chain fallback w/ dynamic URL
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:158:7 › cli codegen › should work with TrustedTypes
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:138:7 › cli codegen › should upload multiple files
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:169:7 › cli codegen › should clear files
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox-page] › page/page-click-scroll.spec.ts:41:3 › should scroll into view display:contents
⚠️ [firefox-page] › page/page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position
⚠️ [firefox-page] › page/page-click.spec.ts:99:3 › should click the 1x1 div
⚠️ [firefox-page] › page/page-click.spec.ts:982:3 › should click a button that is overlayed by a permission popup
⚠️ [firefox-page] › page/page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position
⚠️ [firefox-page] › page/elementhandle-wait-for-element-state.spec.ts:117:3 › should wait for stable position
⚠️ [firefox-page] › page/page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position
⚠️ [firefox-library] › library/tracing.spec.ts:412:14 › should produce screencast frames scale
⚠️ [firefox-page] › page/elementhandle-wait-for-element-state.spec.ts:117:3 › should wait for stable position
⚠️ [chromium-library] › library/browsercontext-credentials.spec.ts:55:1 › should work with correct credentials @smoke
⚠️ [chromium-library] › library/headful.spec.ts:113:3 › should close browser after context menu was triggered
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:196:7 › cli codegen › should not target selector preview by text regexp
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:88:5 › should work with locator.hover()
⚠️ [chromium-page] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [chromium-library] › library/emulation-focus.spec.ts:190:12 › should trigger hover state concurrently
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:609:7 › cli codegen › should assert value on disabled input
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [webkit-page] › page/page-evaluate.spec.ts:169:3 › should work right after framenavigated
⚠️ [webkit-page] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [webkit-page] › page/workers.spec.ts:243:3 › should support offline
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:562:7 › cli codegen › should assert value
⚠️ [webkit-library] › library/selector-generator.spec.ts:504:5 › selector generator › should generate exact label when necessary
⚠️ [webkit-page] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [webkit-page] › page/page-drag.spec.ts:289:5 › Drag and drop › should work with the helper method
⚠️ [webkit-page] › page/page-mouse.spec.ts:221:3 › should tween mouse movement
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:57:5 › mobile viewport › should be detectable by Modernizr
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:66:5 › mobile viewport › should detect touch when applying viewport with touches
⚠️ [webkit-library] › library/modernizr.spec.ts:33:3 › safari-14-1
⚠️ [webkit-library] › library/trace-viewer.spec.ts:893:1 › should display waitForLoadState even if did not wait for it
⚠️ [webkit-library] › library/tracing.spec.ts:412:14 › should produce screencast frames fit
⚠️ [webkit-library] › library/tracing.spec.ts:412:14 › should produce screencast frames crop
2 interrupted ⚠️ [firefox-page] › page/page-click-react.spec.ts:118:3 › should not retarget when element is recycled on hover
⚠️ [firefox-page] › page/page-click-scroll.spec.ts:19:3 › should not hit scroll bar

186044 passed, 8159 skipped, 1291 did not run
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

Test results for "tests 1"

2 flaky ⚠️ [firefox-page] › page/page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position
⚠️ [chromium-page] › page/page-event-request.spec.ts:110:3 › should report navigation requests and responses handled by service worker

27372 passed, 671 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt requested a review from dgozman April 19, 2024 22:40
@mxschmitt mxschmitt merged commit a932222 into microsoft:main Apr 20, 2024
29 of 30 checks passed
mxschmitt added a commit to mxschmitt/playwright that referenced this pull request May 14, 2024
mxschmitt added a commit that referenced this pull request May 14, 2024
This reverts commit a932222.

Closes #30797 - maybe there
is a better way to get the page height?
`document.documentElement.scrollHeight` seems to not work on Firefox.
Relates #30770
mxschmitt pushed a commit that referenced this pull request May 14, 2024
…ents (#30001)" (#30801)

This PR cherry-picks the following commits:

- b06c1df

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Content in dialog element cannot be masked
2 participants