Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure MacOS framework package to fix malformed Framework errors #21536

Merged
merged 7 commits into from
Aug 4, 2024

Conversation

vraspar
Copy link
Contributor

@vraspar vraspar commented Jul 28, 2024

Description

Refactor framework directory structure for MacOS packages

Motivation and Context

Apple started enforcing specific framework structure for MacOS packages. We need to change how we package for MacOS to follow the guidelines

Fixes following issue: Malformed Framework

@vraspar vraspar requested review from skottmckay and edgchen1 July 28, 2024 20:08
@vraspar
Copy link
Contributor Author

vraspar commented Jul 28, 2024

Artifacts

@skottmckay
Copy link
Contributor

Based on the zip file size from a build of main vs the branch it looks like 'Current' is being stored as a copy in the zip instead of a symlink. Is there an option we need to specify to avoid that?

image

@edgchen1
Copy link
Contributor

Based on the zip file size from a build of main vs the branch it looks like 'Current' is being stored as a copy in the zip instead of a symlink. Is there an option we need to specify to avoid that?

image

yeah, looks like this zip call should be updated to allow symlinks:

zip -r "${ARTIFACTS_STAGING_DIR}/${POD_ARCHIVE_BASENAME}" ./* --exclude "${PODSPEC_BASENAME}"

@vraspar
Copy link
Contributor Author

vraspar commented Jul 29, 2024

Based on the zip file size from a build of main vs the branch it looks like 'Current' is being stored as a copy in the zip instead of a symlink. Is there an option we need to specify to avoid that?
image

yeah, looks like this zip call should be updated to allow symlinks:

zip -r "${ARTIFACTS_STAGING_DIR}/${POD_ARCHIVE_BASENAME}" ./* --exclude "${PODSPEC_BASENAME}"

Updated the zip call, but it seems that there might be other place causing it: https://aiinfra.visualstudio.com/Lotus/_build/results?buildId=520232&view=results

@vraspar vraspar force-pushed the vraspar/macos-framework branch from c1d5776 to 9eacb33 Compare August 1, 2024 20:01
@vraspar vraspar force-pushed the vraspar/macos-framework branch from 9eacb33 to e8e6b31 Compare August 1, 2024 20:22
@vraspar vraspar marked this pull request as ready for review August 2, 2024 21:44
@vraspar vraspar merged commit 88c811b into main Aug 4, 2024
95 of 98 checks passed
@vraspar vraspar deleted the vraspar/macos-framework branch August 4, 2024 19:47
@skottmckay skottmckay added the release:1.19.0 Cherry pick to ORT 1.19 label Aug 7, 2024
prathikr pushed a commit that referenced this pull request Aug 7, 2024
…#21536)

### Description

Refactor framework directory structure for MacOS packages

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Apple started enforcing specific [framework
structure](https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPFrameworks/Concepts/FrameworkAnatomy.html)
for MacOS packages. We need to change how we package for MacOS to follow
the guidelines

Fixes following issue: [Malformed
Framework](microsoft/onnxruntime-swift-package-manager#19
)
prathikr pushed a commit that referenced this pull request Aug 9, 2024
…#21536)

### Description

Refactor framework directory structure for MacOS packages

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Apple started enforcing specific [framework
structure](https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPFrameworks/Concepts/FrameworkAnatomy.html)
for MacOS packages. We need to change how we package for MacOS to follow
the guidelines

Fixes following issue: [Malformed
Framework](microsoft/onnxruntime-swift-package-manager#19
)
@prathikr prathikr added the cherry-picked Cherry-picked for a cherrypicks branch label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked Cherry-picked for a cherrypicks branch release:1.19.0 Cherry pick to ORT 1.19
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants