Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Malformed Framework #19

Open
tqtifnypmb opened this issue Jul 3, 2024 · 4 comments
Open

Malformed Framework #19

tqtifnypmb opened this issue Jul 3, 2024 · 4 comments

Comments

@tqtifnypmb
Copy link

tqtifnypmb commented Jul 3, 2024 •
edited
Loading

Screenshot 2024-07-03 at 16 37 46

Version: 1.18.0
OS: macOS
@skottmckay
Copy link
Contributor

Apparently this has only recently been enforced. The issue is with the onnxruntime package from the look of it, so we'll try to fix it there.

Do you see the issue when trying to upload an iOS app or a macOS app?

@tqtifnypmb
Copy link
Author

macOS app

@vraspar vraspar mentioned this issue Jul 28, 2024
Merged
vraspar added a commit to microsoft/onnxruntime that referenced this issue Aug 4, 2024
@vraspar
Restructure MacOS framework package to fix malformed Framework errors (…
88c811b 
…#21536)

### Description

Refactor framework directory structure for MacOS packages

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Apple started enforcing specific [framework
structure](https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPFrameworks/Concepts/FrameworkAnatomy.html)
for MacOS packages. We need to change how we package for MacOS to follow
the guidelines

Fixes following issue: [Malformed
Framework](microsoft/onnxruntime-swift-package-manager#19
)
prathikr pushed a commit to microsoft/onnxruntime that referenced this issue Aug 7, 2024
@vraspar @prathikr
Restructure MacOS framework package to fix malformed Framework errors (…
48ea164 
…#21536)

### Description

Refactor framework directory structure for MacOS packages

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Apple started enforcing specific [framework
structure](https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPFrameworks/Concepts/FrameworkAnatomy.html)
for MacOS packages. We need to change how we package for MacOS to follow
the guidelines

Fixes following issue: [Malformed
Framework](microsoft/onnxruntime-swift-package-manager#19
)
prathikr pushed a commit to microsoft/onnxruntime that referenced this issue Aug 9, 2024
@vraspar @prathikr
Restructure MacOS framework package to fix malformed Framework errors (…
44bcc20 
…#21536)

### Description

Refactor framework directory structure for MacOS packages

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Apple started enforcing specific [framework
structure](https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPFrameworks/Concepts/FrameworkAnatomy.html)
for MacOS packages. We need to change how we package for MacOS to follow
the guidelines

Fixes following issue: [Malformed
Framework](microsoft/onnxruntime-swift-package-manager#19
)
@tqtifnypmb
Copy link
Author

tqtifnypmb commented Aug 12, 2024 •
edited
Loading

Do we need to wait for the next release to have this fixed? Or just simply refetch the package.

@edgchen1
Copy link
Contributor

You will need to wait until the 1.19 release. I think that will happen soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skottmckay @tqtifnypmb @edgchen1