Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that money/small money are within correct range for bulkcopy #2379

Merged
merged 5 commits into from
Apr 4, 2024
Merged

Check that money/small money are within correct range for bulkcopy #2379

merged 5 commits into from
Apr 4, 2024

Conversation

Jeffery-Wasty
Copy link
Contributor

Fixes #2309

@codecov Codecov
Copy link

codecov bot commented Apr 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.23%. Comparing base (78bdefd) to head (7ee5be8).

❗ Current head 7ee5be8 differs from pull request most recent head 13fb1df. Consider uploading reports for the commit 13fb1df to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2379      +/-   ##
============================================
+ Coverage     50.21%   50.23%   +0.02%     
- Complexity     3841     3848       +7     
============================================
  Files           145      145              
  Lines         33358    33360       +2     
  Branches       5654     5654              
============================================
+ Hits          16750    16759       +9     
+ Misses        14221    14211      -10     
- Partials       2387     2390       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lilgreenbird lilgreenbird added this to the 12.7.0 milestone Apr 3, 2024
@Jeffery-Wasty Jeffery-Wasty marked this pull request as ready for review April 4, 2024 17:35
barryw-mssql
barryw-mssql previously approved these changes Apr 4, 2024
View reviewed changes
lilgreenbird
lilgreenbird previously requested changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@lilgreenbird lilgreenbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run formatter

tkyc
tkyc previously approved these changes Apr 4, 2024
View reviewed changes
@Jeffery-Wasty Jeffery-Wasty merged commit 5b3f32e into main Apr 4, 2024
3 of 17 checks passed
@Jeffery-Wasty Jeffery-Wasty deleted the moneySmallMoneyFix branch April 4, 2024 21:35
Jeffery-Wasty added a commit that referenced this pull request Apr 10, 2024
@Jeffery-Wasty
Changes to MONEY/SMALLMONEY PR (#2379) (#2383)
67f7fab 
* Changes as per prior code review

* setupMoneyTests can be added to beforeAll, it should be ran each time

* Passed in wrong values for tests
@Jeffery-Wasty Jeffery-Wasty mentioned this pull request May 17, 2024
Merged
tkyc added a commit that referenced this pull request May 27, 2024
@tkyc
Revert "Check that money/small money are within correct range for bul…
a251fdc 
…kcopy (#2379)"

This reverts commit 5b3f32e.
tkyc added a commit that referenced this pull request May 27, 2024
@tkyc
Revert "Changes to MONEY/SMALLMONEY PR (#2379) (#2383)"
3aa370b 
This reverts commit 67f7fab.
@Eng-Fouad Eng-Fouad mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barryw-mssql barryw-mssql barryw-mssql approved these changes

@tkyc tkyc tkyc approved these changes

@lilgreenbird lilgreenbird lilgreenbird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
MSSQL JDBC
Status: Closed/Merged PRs
Milestone
12.7.0
Development

Successfully merging this pull request may close these issues.

When I try to insert the value beyond the range, it inserting wrong values with small money/money.
4 participants
@Jeffery-Wasty @lilgreenbird @tkyc @barryw-mssql