Review fixes

microsoft · Apr 4, 2024 · 70812b9 · 70812b9
1 parent d0c15e8
commit 70812b9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyMoneyTest.java b/src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyMoneyTest.java
@@ -25,17 +25,17 @@
 
 import com.microsoft.sqlserver.testframework.AbstractSQLGenerator;
 import com.microsoft.sqlserver.testframework.AbstractTest;
+import com.microsoft.sqlserver.testframework.Constants;
 import com.microsoft.sqlserver.testframework.PrepUtil;
 
 
 /**
- *
- *
+ * Tests money/smallmoney limits with BulkCopy
  */
 @RunWith(JUnitPlatform.class)
 public class BulkCopyMoneyTest extends AbstractTest {
-    static String encoding = "UTF-8";
-    static String delimiter = ",";
+    static String encoding = Constants.UTF8;
+    static String delimiter = Constants.COMMA;
     static String destTableName = AbstractSQLGenerator.escapeIdentifier(RandomUtil.getIdentifier("moneyBulkCopyDest"));
     static String destTableName2 = AbstractSQLGenerator.escapeIdentifier(RandomUtil.getIdentifier("moneyBulkCopyDest"));
     @Test
@@ -88,7 +88,6 @@ private void testMoneyWithBulkCopy(Connection conn, SQLServerBulkCSVFileRecord f
             fileRecord.addColumnMetadata(1, "c1", java.sql.Types.DECIMAL, 10, 4); // with smallmoney
             fileRecord.addColumnMetadata(2, "c2", java.sql.Types.DECIMAL, 19, 4); // with money
 
-
             bulkCopy.setDestinationTableName(destTableName);
             bulkCopy.writeToServer(fileRecord);
 
@@ -97,7 +96,6 @@ private void testMoneyWithBulkCopy(Connection conn, SQLServerBulkCSVFileRecord f
                 bcOperation.setDestinationTableName(destTableName2);
                 bcOperation.writeToServer(rs);
             }
-
         }
     }
 

diff --git a/src/test/java/com/microsoft/sqlserver/testframework/Constants.java b/src/test/java/com/microsoft/sqlserver/testframework/Constants.java
@@ -179,6 +179,7 @@ private Constants() {}
     public static final String SEND_TEMPORAL_DATATYPES_AS_STRING_FOR_BULK_COPY = "SENDTEMPORALDATATYPESASSTRINGFORBULKCOPY";
     public static final String PREPARE_METHOD = "PREPAREMETHOD";
     public static final String CONFIG_PROPERTIES_FILE = "config.properties";
+    public static final String UTF8 = "UTF-8";
 
     public enum LOB {
         CLOB,