-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Receive API Support #4182
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4182 +/- ##
==========================================
+ Coverage 85.31% 85.88% +0.56%
==========================================
Files 56 56
Lines 15457 15475 +18
==========================================
+ Hits 13187 13290 +103
+ Misses 2270 2185 -85 ☔ View full report in Codecov by Sentry. |
9398cd9
to
e2500a6
Compare
e2500a6
to
a1f2339
Compare
1G send sometimes hit assert here Line 688 in a1f2339
|
hit Line 352 in a1f2339
|
RecvBuffer->ReadLength seems to have synchronization issue. Especially after resizing chunk |
This guy does bad. Not necessarily the cap split the draining range. Or simply split ranges maybe not indicated to an app. Line 926 in a1f2339
|
ddb7d2e
to
2fcb778
Compare
Where to handle remaining ReadPendingLength. App? api.c? stream_recv.c? recv_buff.c? |
30d6067
to
714042c
Compare
d621df0
to
8893063
Compare
ready to go |
@ami-GS can you update the docs too? I review the code and it looks good to me. But since it's my PR I can't approve. You will have to and then merge once you get the docs in. |
The general API doc. I will update that other PR sometime later, after this is merged. |
Co-authored-by: Nick Banks <[email protected]>
Co-authored-by: Nick Banks <[email protected]>
* WIP * Fixes * Simplify * fix * Fix * Fix more bugs * Fix clog and .net * Fixes * Improvements * Undo a merge issue * Another merge issue * Simple test * remove fprintf * fix signature to upto 255. add Large send case * 1G Multi receive * fix drain bug * kernel test * fix * fix * unused variable * compare data * tmp * test cases * 95% works * remove fprintf in core * Fix Range copy * fix type mimatch * cleanup * Fix stall issue * rollback * retry if length is 0 * remove continue to reset Readpending in QuicStreamReceiveComplete * stop enablling send with pending data (race condition exists) * fix QuicRecvBufferHasUnreadData * rollback for recv_buff lock bug then return earlier not to indicate FIN bit * fix * fix * reduce test buffer size for CI speed * update document * add back buffer count caution * Update docs/api/StreamReceiveComplete.md Co-authored-by: Nick Banks <[email protected]> * Update docs/api/StreamReceiveComplete.md Co-authored-by: Nick Banks <[email protected]> * logical conflicts --------- Co-authored-by: ami-GS <[email protected]>
Description
Adds a settings for apps to configure streams to support multiple parallel receives.
Testing
TODO
Documentation
TODO