fix QuicRecvBufferHasUnreadData

microsoft · Jul 8, 2024 · 2fcb778 · 2fcb778
1 parent 7246587
commit 2fcb778
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/core/recv_buffer.c b/src/core/recv_buffer.c
@@ -154,6 +154,9 @@ QuicRecvBufferHasUnreadData(
     _In_ QUIC_RECV_BUFFER* RecvBuffer
     )
 {
+    if (RecvBuffer->ReadPendingLength != 0 && RecvBuffer->RecvMode != QUIC_RECV_BUF_MODE_MULTIPLE) {
+        return FALSE;
+    }
     const QUIC_SUBRANGE* FirstRange = QuicRangeGetSafe(&RecvBuffer->WrittenRanges, 0);
     if (FirstRange == NULL || FirstRange->Low != 0) {
         return FALSE;

diff --git a/src/tools/spin/spinquic.cpp b/src/tools/spin/spinquic.cpp
@@ -1026,11 +1026,7 @@ void Spin(Gbs& Gb, LockableVector<HQUIC>& Connections, std::vector<HQUIC>* Liste
                 std::lock_guard<std::mutex> Lock(ctx->Lock);
                 auto Stream = ctx->TryGetStream();
                 if (Stream == nullptr) continue;
-                auto StreamCtx = SpinQuicStream::Get(Stream);
-                bool Enable = GetRandom(2) == 0;
-                if (!Enable || StreamCtx->PendingRecvLength == UINT64_MAX) {
-                    MsQuic.StreamReceiveSetEnabled(Stream, Enable);
-                }
+                MsQuic.StreamReceiveSetEnabled(Stream, GetRandom(2) == 0);
             }
             break;
         }