Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generates default icons when not present #5025

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Generates default icons when not present #5025

merged 4 commits into from
Jul 26, 2024

Conversation

andrueastman
Copy link
Member

Fixes #4993

@andrueastman andrueastman requested a review from a team as a code owner July 26, 2024 08:17
@baywet baywet enabled auto-merge July 26, 2024 12:09
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

auto-merge was automatically disabled July 26, 2024 12:14

Pull Request is not mergeable

@baywet baywet merged commit 44d61a4 into main Jul 26, 2024
207 checks passed
@baywet baywet deleted the andrueastman/defaultIcons branch July 26, 2024 12:15
@baywet baywet mentioned this pull request Aug 1, 2024
Merged
@andrueastman andrueastman mentioned this pull request Aug 16, 2024
Closed
andrueastman pushed a commit that referenced this pull request Aug 19, 2024
Revert "Merge pull request #5025 from microsoft/andrueastman/defaultI…
de19798 
…cons"

This reverts commit 44d61a4, reversing
changes made to 1983ca4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When generating plugin with Kiota and trying to upload the app, I got an error about missing files (icons)
2 participants
@andrueastman @baywet