Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When generating plugin with Kiota and trying to upload the app, I got an error about missing files (icons) #4993

Closed
maisarissi opened this issue Jul 18, 2024 · 6 comments · Fixed by #5025
Assignees
Labels
Milestone

Comments

@maisarissi
Copy link
Contributor

Today Kiota generates all files necessary to sideload the app and have the plugin showing in Copilot.
The only exception is the icons node in manifest.json file.

Today we generate the manifest.json with the following information:

"icons": {
    "color": "color.png",
    "outline": "outline.png"
}

(both are required for the manifest file)

This works well when TTK is used to create the project, as TTK adds the following as default icons when creating the project:
color.png
outline.png

However, if I'm using Kiota only, this will cause an error as the files are not actually added to the output directory.

Expected:
I expect that Kiota will generate everything I need to upload a plugin with no errors
When re-generating, I expect Kiota will not override my current icons, whether I keep the default ones or add my customized owns

@maisarissi maisarissi added the status:waiting-for-triage An issue that is yet to be reviewed or assigned label Jul 18, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Jul 18, 2024
@sebastienlevert
Copy link
Contributor

We should also probably with with Daniella to get custom icons for Kiota. Just to make it clear this is not TTK related.

@andrueastman andrueastman moved this from Needs Triage 🔍 to Todo 📃 in Kiota Jul 19, 2024
@andrueastman andrueastman added enhancement New feature or request and removed status:waiting-for-triage An issue that is yet to be reviewed or assigned labels Jul 19, 2024
@baywet baywet moved this from Todo 📃 to Blocked 🔒 in Kiota Jul 19, 2024
@baywet baywet added this to the Kiota v1.17 milestone Jul 19, 2024
@baywet
Copy link
Member

baywet commented Jul 19, 2024

We'll hold working on that until you have the graphics here.

@petrhollayms
Copy link
Contributor

@maisarissi is this just about bundling the file with the standard file names as described above? Or any parametrization of these files?

What exactly shall happen here?

I expect Kiota will not override my current icons

@maisarissi
Copy link
Contributor Author

I'm working with Daniella (design team) to get the right graphics to use and we should have an update next week.
We should just add the files to the output directory together with the other generated files when generating the plugin. No parametrization needed.

About the regeneration:
Let's assume I have generated my plugin using Kiota and I have replaced the default icon files with my customized ones. When doing any changes to the plugin (like changing endpoint selection, type of plugin or any other thing) and regenerating the plugin, the icons shouldn't be overridden/replaced with the default ones.

@maisarissi
Copy link
Contributor Author

maisarissi commented Jul 25, 2024

After internal meeting, @baywet and I agreed on having a place holder icon while waiting for the icons provided by design/marketing so we can move forward with this issue and not get blocked by public preview. Once we have the final icons ready, we can replace the place holders.
The icons to be used as place holders were shared internally.

The requirements for the icons are as below:

Color version: PNG icon. Size 192x192.
Outline version: PNG outline icon. The border color needs to be white. Size 32x32.

@baywet
Copy link
Member

baywet commented Jul 25, 2024

We should configure these images as resources in the assembly to avoid path management issues.
https://stackoverflow.com/a/41106851

@andrueastman andrueastman self-assigned this Jul 26, 2024
@andrueastman andrueastman moved this from Blocked 🔒 to Todo 📃 in Kiota Jul 26, 2024
@github-project-automation github-project-automation bot moved this from Todo 📃 to Done ✔️ in Kiota Jul 26, 2024
andrueastman added a commit that referenced this issue Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants