-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When generating plugin with Kiota and trying to upload the app, I got an error about missing files (icons) #4993
Comments
We should also probably with with Daniella to get custom icons for Kiota. Just to make it clear this is not TTK related. |
We'll hold working on that until you have the graphics here. |
@maisarissi is this just about bundling the file with the standard file names as described above? Or any parametrization of these files? What exactly shall happen here?
|
I'm working with Daniella (design team) to get the right graphics to use and we should have an update next week. About the regeneration: |
After internal meeting, @baywet and I agreed on having a place holder icon while waiting for the icons provided by design/marketing so we can move forward with this issue and not get blocked by public preview. Once we have the final icons ready, we can replace the place holders. The requirements for the icons are as below: Color version: PNG icon. Size 192x192. |
We should configure these images as resources in the assembly to avoid path management issues. |
Today Kiota generates all files necessary to sideload the app and have the plugin showing in Copilot.
The only exception is the
icons
node inmanifest.json
file.Today we generate the manifest.json with the following information:
(both are required for the manifest file)
This works well when TTK is used to create the project, as TTK adds the following as default icons when creating the project:
color.png
outline.png
However, if I'm using Kiota only, this will cause an error as the files are not actually added to the output directory.
Expected:
I expect that Kiota will generate everything I need to upload a plugin with no errors
When re-generating, I expect Kiota will not override my current icons, whether I keep the default ones or add my customized owns
The text was updated successfully, but these errors were encountered: