- fixes #1393 a bug where models descriptions would not be deterministic #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
requested review from
andrueastman,
darrelmiller,
zengin,
MIchaelMainer,
ddyett,
peombwa,
nikithauc and
ramsessanchez
as code owners
baywet
added
the
generator
|
Kudos, SonarCloud Quality Gate passed! |
andrueastman
approved these changes
Mar 16, 2022
| Description = currentNode.GetPathItemDescription(Constants.DefaultOpenApiLabel) | ||
| Description = schema.Description ?? (string.IsNullOrEmpty(schema.Reference?.Id) ? | ||
| currentNode.GetPathItemDescription(Constants.DefaultOpenApiLabel) : | ||
| null),// if it's a referenced component, we shouldn't use the path item description as it makes it indeterministic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.