Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models description is non-deterministic #1393

Closed
baywet opened this issue Mar 15, 2022 · 0 comments · Fixed by #1394
Closed

models description is non-deterministic #1393

baywet opened this issue Mar 15, 2022 · 0 comments · Fixed by #1394
Assignees
Labels
fixed generator Issues or improvements relater to generation capabilities. kiota Block Kiota. type:bug A broken experience

Comments

@baywet
Copy link
Member

baywet commented Mar 15, 2022

When a model has no description itself and is referred from a couple of path items, the description is non-deterministic (race condition) depending on which path item gets processed first.

This is because we default back to the path item description when a model has no description, which we shouldn't do when that model is a referenced schema.

This behaviour impacts sdk consumers in the sense that they get inaccurate descriptions, but more importantly it impacts us by generating larger diffs in weekly generations, making changes longer to process.

@baywet baywet added type:bug A broken experience generator Issues or improvements relater to generation capabilities. kiota Block Kiota. labels Mar 15, 2022
@baywet baywet added this to the Community Preview milestone Mar 15, 2022
@baywet baywet self-assigned this Mar 15, 2022
@baywet baywet added this to Kiota Mar 15, 2022
@baywet baywet moved this to Todo in Kiota Mar 15, 2022
@baywet baywet moved this from Todo to In Progress in Kiota Mar 15, 2022
@baywet baywet added the fixed label Mar 15, 2022
baywet added a commit that referenced this issue Mar 16, 2022
- fixes #1393 a bug where models descriptions would not be deterministic
Repository owner moved this from In Progress to Done in Kiota Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed generator Issues or improvements relater to generation capabilities. kiota Block Kiota. type:bug A broken experience
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant