Replacing System.AggregateException with custom aggregate exception #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will also file the discovered bug with the AI Telemetry team |
dustinburson
reviewed
Jul 9, 2021
namalu
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
System.AggregateExceptioncontains more than 10 inner exceptions, the AI Telemetry Pipeline converts this into a custom, internal exception (InnerExceptionCountExceededException). This results in the following:Messageattribute of the surroundingExceptionTelemetyobject from getting populated.This results in no actionable message being shown to a developer/customer. Even if there was one, it would be constructed with only the first 10 exceptions.
This PR creates a new Aggregate Exception which will not be converted by the current AI logic above. This will result in the expected aggregate message being displayed to the customer.