Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing System.AggregateException with custom aggregate exception #120

Merged
merged 5 commits into from
Jul 9, 2021
Merged

Replacing System.AggregateException with custom aggregate exception #120

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0f874b
Replacing System.AggregateException with custom aggregate exception
rogordon01 Jul 9, 2021
22b8108
Adding unit test
rogordon01 Jul 9, 2021
84be85e
Revert "Replacing System.AggregateException with custom aggregate exc…
rogordon01 Jul 9, 2021
5d550a1
Revert "Adding unit test"
rogordon01 Jul 9, 2021
f8c322d
Log inner exception when AggregateException is received
rogordon01 Jul 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/lib/Microsoft.Health.Logger/Telemetry/IomtTelemetryLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,15 @@ public virtual void LogMetric(Common.Telemetry.Metric metric, double metricValue

public virtual void LogError(Exception ex)
{
_telemetryClient.TrackException(ex);
if (ex is AggregateException e)
{
// Address bug https://github.com/microsoft/iomt-fhir/pull/120
LogAggregateException(e);
}
else
{
_telemetryClient.TrackException(ex);
}
}

public virtual void LogTrace(string message)
Expand All @@ -41,5 +49,18 @@ public void LogMetricWithDimensions(Common.Telemetry.Metric metric, double metri
EnsureArg.IsNotNull(metric);
metric.LogMetric(_telemetryClient, metricValue);
}

private void LogAggregateException(AggregateException e)
{
if (e.InnerException != null)
{
_telemetryClient.TrackException(e.InnerException);
}

foreach (var exception in e.InnerExceptions)
{
_telemetryClient.TrackException(exception);
}
}
}
}