Log shim panic logs in containerd. #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we no longer need a containerd PR here? |
|
Nope. Whatever is written on the stderr of the shim binary delete instance will be logged by containerd automatically. |
|
Sweet ok! |
dcantah
approved these changes
Feb 23, 2021
kevpar
reviewed
Feb 24, 2021
kevpar
reviewed
Feb 24, 2021
|
Can you make sure you have tested by inserting panic at various points in the code, and made sure the stack is correctly picked up by |
ambarve
force-pushed
the
shim_panic_logs
branch
2 times, most recently
from
8140e5b to
2b171cb
Compare
kevpar
reviewed
Feb 25, 2021
Currently hcsshim writes the shim panic logs in a file named panic.log inside the sandbox directory. However, those logs are never logged in containerd and they get lost when the sandbox container is removed. This change allows the shim to log these panic logs to containerd before deleting them. Signed-off-by: Amit Barve <[email protected]>
ambarve
force-pushed
the
shim_panic_logs
branch
from
2b171cb to
11ec1d1
Compare
|
@kevpar I have tested this by adding panic at different locations in hcsshim code and verified that the panic log shows up in both ETW and containerd events. Can you please take another look? |
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#173, microsoft#839, microsoft#856, microsoft#877, microsoft#881, microsoft#886, microsoft#887, microsoft#888, microsoft#889, microsoft#890, microsoft#893, microsoft#894, microsoft#896, microsoft#899, microsoft#900, microsoft#902, microsoft#904, microsoft#905, microsoft#906, microsoft#907, microsoft#908, microsoft#910, microsoft#912, microsoft#913, microsoft#914, microsoft#916, microsoft#918, microsoft#923, microsoft#925, microsoft#926, microsoft#928, microsoft#929, microsoft#932, microsoft#933, microsoft#934, microsoft#938, microsoft#939, microsoft#942, microsoft#943, microsoft#945, microsoft#946, microsoft#947, microsoft#949, microsoft#951, microsoft#952, microsoft#954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently hcsshim writes the shim panic logs in a file named panic.log inside the sandbox
directory. However, those logs are never logged in containerd and they get lost when the
sandbox container is removed. This change allows the shim to log these panic logs to
containerd before deleting them.
Signed-off-by: Amit Barve [email protected]