-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for logging binary #896
Add support for logging binary #896
Conversation
This is still a draft but a quick summary of the entire flow for this work/anything extra that you think would be helpful to know for review of this would be good to have 😃 |
ee53852
to
eeff4aa
Compare
@anmaxvl Thanks for the summary :) By the way, does this need to be a draft? Is there more coming and this is just to get feedback early or? |
eeff4aa
to
0a3af6f
Compare
for early feedback and thanks for giving one! still need to validate the |
d7ddf5f
to
9e2a1e2
Compare
ab2654a
to
198776f
Compare
LOVE the tests. Just a few really minor questions/comments :) |
a26974b
to
5f5dc90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments but overall LGTM :)
5f5dc90
to
ae06a62
Compare
Add integrations tests Signed-off-by: Maksim An <[email protected]>
ae06a62
to
966a054
Compare
Related work items: microsoft#173, microsoft#839, microsoft#856, microsoft#877, microsoft#881, microsoft#886, microsoft#887, microsoft#888, microsoft#889, microsoft#890, microsoft#893, microsoft#894, microsoft#896, microsoft#899, microsoft#900, microsoft#902, microsoft#904, microsoft#905, microsoft#906, microsoft#907, microsoft#908, microsoft#910, microsoft#912, microsoft#913, microsoft#914, microsoft#916, microsoft#918, microsoft#923, microsoft#925, microsoft#926, microsoft#928, microsoft#929, microsoft#932, microsoft#933, microsoft#934, microsoft#938, microsoft#939, microsoft#942, microsoft#943, microsoft#945, microsoft#946, microsoft#947, microsoft#949, microsoft#951, microsoft#952, microsoft#954
Logging binary support and integration tests Signed-off-by: Maksim An <[email protected]>
Summary
This PR adds logging binary support (like in containerd/containerd#3085).
Just like in the above PR:
Flow
The flow (assuming that jterry75/cri#82 is also merged) as follows:
log_path
config:log_path
needs to be a valid url (i.e."binary:\\\\\\path\\to\\binary.exe"
won't work, sinceurl.Parse
will fail)You'll notice that
ctr-x-stdout
andctr-x-stderr
pipes won't be created,binary-x-stdout
andbinary-x-stderr
will replace them.This will break the previous "feature" of being able to set
log_path
and docrictl attach
at the same time.TODO
wait
channel is necessary, since earlier testing was failing to run the binarySigned-off-by: Maksim An [email protected]