Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix license attribution #1

Merged
merged 1 commit into from
Dec 25, 2021
Merged

Fix license attribution #1

merged 1 commit into from
Dec 25, 2021

Conversation

3nprob
Copy link

@3nprob 3nprob commented Dec 25, 2021

Mistakenly removed in 04c7143

Fix license attribution
305618d 
Mistakenly removed in 04c7143
@ryanbnl
Copy link

ryanbnl commented Dec 25, 2021

Merge or no cigar :-)

@serprex
Copy link

serprex commented Dec 25, 2021 •
edited
Loading

All 5 commits should be reverted

Someone on reddit pointed out this issue impacts multiple forks: https://www.reddit.com/r/opensource/comments/roa9xz/comment/hpx67x2

The bot should ignore forks. & skip if a file is already existing. I'm not sure who has access to the bot's source & deployment

@3nprob
Copy link
Author

3nprob commented Dec 25, 2021 •
edited
Loading

https://www.reddit.com/r/opensource/comments/roa9xz/comment/hpx67x2

Altfront links:

https://libredd.it/r/opensource/comments/roa9xz/comment/hpx67x2

http://kphht2jcflojtqte4b4kyx7p2ahagv4debjj32nre67dxz7y57seqwyd.onion/r/opensource/comments/roa9xz/comment/hpx67x2

https://teddit.adminforge.de/r/opensource/comments/roa9xz/comment/hpx67x2

http://ibarajztopxnuhabfu7fg6gbudynxofbnmvis3ltj6lfx47b6fhrd5qd.onion/r/opensource/comments/roa9xz/comment/hpx67x2

@3nprob
Copy link
Author

3nprob commented Dec 25, 2021 •
edited
Loading

All 5 commits should be reverted

Maybe make a complimentary PR for that? :) Perhaps split out 04c7143 to facilitate smooth merging.

@msftgits msftgits merged commit 6d2ab64 into microsoft:master Dec 25, 2021
@3nprob 3nprob deleted the fix-license branch December 25, 2021 17:35
deadblackclover referenced this pull request Dec 25, 2021
@microsoftopensource
LICENSE updated to template
04c7143
veselcraft
veselcraft reviewed Dec 25, 2021
View reviewed changes
Copy link

@veselcraft veselcraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that dot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veselcraft veselcraft veselcraft left review comments

@kblok kblok kblok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.