Commit
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,21 @@ | ||
| MIT License | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong. 
leonheld
|
||
|
|
||
| Copyright (c) Microsoft Corporation. | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong. |
||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong. |
||
60 comments
on commit 04c7143
There was a problem hiding this comment.
Why info about creator of software is removed in this commit?
There was a problem hiding this comment.
I strongly recommend Mozilla Public License v2.0 for free & open source tools / libraries. It protects the code like GPL yet allows inclusion for any kind of project commercial/close/open etc.
There was a problem hiding this comment.
Why the dot at the end is removed? Are you ashamed of that dot?
Just kidding. Why you removed the author's name?
There was a problem hiding this comment.
There was a problem hiding this comment.
Remember microsoft and java?
There was a problem hiding this comment.
Ummm, the copyright notice is supposed to be reproduced 😬
There was a problem hiding this comment.
If you ever wanted the real reason why Richard Stallman got "canceled", just look at this commit and it'll make sense.
There was a problem hiding this comment.
Microsoft being microsoft...
There was a problem hiding this comment.
Spaces instead of tabs, huh?
Richard is that you? :)
There was a problem hiding this comment.
So if the fork was the "embrace", is this part of the "extend" phase?
There was a problem hiding this comment.
There was a problem hiding this comment.
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
You speak English in Redmond, right? Or can I copy/paste the Windows code into my own github and change the copyright notice to my name nowadays?
There was a problem hiding this comment.
This commit was performed automatically by a bot. Someone will probably notice and fix the issue manually in a few days. Calm down everyone
There was a problem hiding this comment.
This commit was performed automatically by a bot. Someone will probably notice and fix the issue manually in a few days. Calm down everyone
So they taught their bot to do this then?
There was a problem hiding this comment.
This commit was performed automatically by a bot. Someone will probably notice and fix the issue manually in a few days. Calm down everyone
So they taught their bot to do this then?
I mean, not much in the way of teaching when it just replaces a file. Not hard to automate that.
There was a problem hiding this comment.
This commit was performed automatically by a bot. Someone will probably notice and fix the issue manually in a few days. Calm down everyone
So they taught their bot to do this then?
If you notice, the file changes its indentations. I have the feeling the bot's purpose is to add the LICENSE file if it's not present in the repo so that the project is licensed under MIT automatically. Probably a misconfiguration of this bot is causing the replacement instead of preserving the original license file. But this is just my personal feeling after working with bots like these.
There was a problem hiding this comment.
This commit was performed automatically by a bot. Someone will probably notice and fix the issue manually in a few days. Calm down everyone
What happens when Microsoft removes all of the humans & assimilates them?
There was a problem hiding this comment.
Why would a bot change the punctuation?
There was a problem hiding this comment.
Why would a bot change the punctuation?
Because the bot has probably replaced the file with the bot's own copy. That would explain why indentations and punctuation had changed, other than the copyright owner. That's what the bot did wrong, as it was probably coded to add the file so that the project is automatically licensed under MIT, but did not detect if the file was there already.
There was a problem hiding this comment.
inb4forcepush
There was a problem hiding this comment.
in for the glory
There was a problem hiding this comment.
Add me in screencap
There was a problem hiding this comment.
hi mom
There was a problem hiding this comment.
Dear Microsoft. Why?
There was a problem hiding this comment.
Man, I'd hate to the the dev who was working on xmas day who made a mistake and is now being vilified for it .... chin up!
There was a problem hiding this comment.
it seems like everyone here must have never made a mistake when making something automated
There was a problem hiding this comment.
Man, I'd hate to the the dev who was working on xmas day who made a mistake and is now being vilified for it .... chin up!
Commit is from 29 days ago... People only noticed just today, when probably no one is going to do anything to fix this, or perhaps ruin the Christmas day for whoever coded this bot, so yeah all this ain't helping much... I feel sorry for that
There was a problem hiding this comment.
This is CP/M all over again.
There was a problem hiding this comment.
@linuxct I kind of feel bad my innocent Reddit question triggered such an outburst and bad rep for Microsoft. I also thought it was just a script bug which Microsoft confirmed with me via e-mail few minutes ago.
There was a problem hiding this comment.
This commit was performed automatically by a bot. Someone will probably notice and fix the issue manually in a few days.
If that's the case, "replacing the license" feels like something that shouldn't be automated. Now all I can ask is how many times has it happened before, and nobody noticed? 🤔
There was a problem hiding this comment.
@linuxct I kind of feel bad my innocent Reddit question triggered such an outburst and bad rep for Microsoft. I also thought it was just a script bug which Microsoft confirmed with me via e-mail few minutes ago.
I mean, it's still a grave licensing issue that's worth bringing up. What's clear is that's been an automation mistake and that it needs to be corrected by a human, just perhaps not on Christmas day. I hope other devs in this conversation understand the situation as well.
Edit: added missing word.
There was a problem hiding this comment.
This commit was performed automatically by a bot. Someone will probably notice and fix the issue manually in a few days.
If that's the case, "replacing the license" feels like something that shouldn't be automated. Now I'll I can ask is how many times has it happened before, and nobody noticed? 🤔
People in Reddit/HackerNews are making lists of other repos where this has happened, for example: health-cards-tests, or ippsample and huggingface-transformers, where the license file was changed from Apache 2.0 to MIT.
There was a problem hiding this comment.
Already fixed
#1
There was a problem hiding this comment.
Spurdo Spärde
There was a problem hiding this comment.
Find all and replace, gone wrong? 🤦♂️
There was a problem hiding this comment.
Yo @microsoftopensource like the good old days, tcp/ip stack, reminds you something? If not, ask old fellow mr Gates.
There was a problem hiding this comment.
does MIT license allow this?
There was a problem hiding this comment.
This commit was performed automatically by a bot. Someone will probably notice and fix the issue manually in a few days.
If that's the case, "replacing the license" feels like something that shouldn't be automated. Now all I can ask is how many times has it happened before, and nobody noticed? thinking
Yeah agreed. If this is a scripting mistake, which it seems to be implied that it is, it shouldn't be taken less lightly.
Licenses are supposed to be serious legal documents/contracts. No one should feel like you're supposed to freely "just update licenses" whenever they feel like it at the ease of a script. It still feels like a big mistake to even feel like that's what you're supposed to be doing, because I believe that's not what you're supposed to be doing with legal documents.
Edit:
According to https://news.ycombinator.com/item?id=29685628 from one of the supposed devs, it seems like it's a script that runs on all repositories and isn't supposed to run on forked ones. Mistakes happen of course, and we have to always remember there are some honest people just trying to do their jobs behind like all of us and not just a corporation.
But still we have to be aware of these issues and protect licenses and such matters at all cost both the devs and the rest of the community.
There was a problem hiding this comment.
Wow, Microsoft. Great moves. Keep it up. Proud of you.
There was a problem hiding this comment.
New slogan for Microsoft: "We steal everyday"
There was a problem hiding this comment.
Tío Microsoft no la cagues pe'
There was a problem hiding this comment.
So that's how you support open source
There was a problem hiding this comment.
Already fixed people chill the hell out.
There was a problem hiding this comment.
this is really funny
also made by a bot
interesting bots they have, ngl
There was a problem hiding this comment.
Ah yes, nice bots you have
There was a problem hiding this comment.
classy
There was a problem hiding this comment.
Remember to license your code with AGPlv2.
Complete and utter removal of this behavior.
There was a problem hiding this comment.
There was a problem hiding this comment.
This commit was performed automatically by a bot. Someone will probably notice and fix the issue manually in a few days. Calm down everyone
6d2ab64 - yup, fixed
There was a problem hiding this comment.
Further info: https://news.ycombinator.com/item?id=29685628
There was a problem hiding this comment.
New slogan for Microsoft: "We steal everyday
Not only do we steal, we automate it
There was a problem hiding this comment.
@microsoftopensource removing open source licensing is more microsoft than including windows 98 programs in windows 11
There was a problem hiding this comment.
for sure it's a mistake, and for sure this is going to be the most commented commit in human history :)
There was a problem hiding this comment.
bad bots, at the image of microsoft, bad company
and no, it's not "funny"
supposed being a bot automating "important" tasks
keep finding that funny, and you'll end up having to worry about log4j season 2
the amount of people trying to find excuses is appalling, to say the least
it's a mistake that should be taken seriously, no supervision, no nothing, needing a hackernews post to take action
sad
There was a problem hiding this comment.
I'm calling Bill...
There was a problem hiding this comment.
I'm in the comments too!
There was a problem hiding this comment.
Stealing Code In A Nutshell :D
There was a problem hiding this comment.
Very interesting situation indeed!
There was a problem hiding this comment.
love it
There was a problem hiding this comment.
So if the fork was the "embrace", is this part of the "extend" phase?
nah, acquiring github was already "embrace", fork = "extend", this is "extinguish"
I'm sorry this happened and posted more details on HackerNews that explain that we've reverted this bot commit, why it happened, and that we'll get this fixed in any other repos, too.