Support pipe message read mode #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This supersedes #78. |
|
I like this approach. Now I think maybe I should take care to ensure that message read mode is supported in my C code that deals with named pipes . |
johnstep
approved these changes
Jun 25, 2018
There was a problem hiding this comment.
LGTM
I verified this on Windows 1803 and it works as expected.
It would have been nice to have the test ensure that DialPipe accepts message-read mode, but it appears that pipe clients returned by CreateFile are always in byte-read mode initially (per https://msdn.microsoft.com/en-us/library/windows/desktop/aa365605(v=vs.85).aspx), except for vSMB named pipes, making that very difficult to verify from a unit test.
|
@jstarks is it possible to tag a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Message read mode is the only read mode supported for vSMB named pipes, which are used to provide named pipe mapping for Hyper-V-isolated Windows containers. Transparently support this mode.