Allow for message pipes in message readmode for Windows named pipes to work. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, we will treat ERROR_MORE_DATA as success and return the remaining number of bytes to be read. |
thaJeztah
suggested changes
Jun 22, 2018
| @@ -181,9 +181,12 @@ func DialPipe(path string, timeout *time.Duration) (net.Conn, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| if state&cPIPE_READMODE_MESSAGE != 0 { | |||
| /** | |||
| Windows support message type pipes in message-read mode only. Removing this check to allow for windows named pipes. | |||
There was a problem hiding this comment.
Looks like this message could be better put as a commit message, and the code removed?
|
@jstarks ptal |
|
This is what I mentioned back in March, moby/moby#36562 (comment), but I never heard back. Is this really the correct fix? Why is the VMBus proxy pipe (assuming that is how it works) a different mode? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: moby/moby#36562 (comment)
The named pipe in Windows is of message type and the handle to the pipe is in message read mode. Removing the check to allow for Windows named pipes to work.