feat(react-slider): adjust slider thumb position #32424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 41 | 36 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 648 | 618 | 5000 | |
| Button | mount | 296 | 311 | 5000 | |
| Field | mount | 1178 | 1148 | 5000 | |
| FluentProvider | mount | 742 | 755 | 5000 | |
| FluentProviderWithTheme | mount | 83 | 103 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 41 | 36 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 86 | 83 | 10 | |
| MakeStyles | mount | 886 | 862 | 50000 | |
| Persona | mount | 1812 | 1738 | 5000 | |
| SpinButton | mount | 1429 | 1428 | 5000 | |
| SwatchPicker | mount | 1705 | 1681 | 5000 |
fabricteam
reviewed
Aug 30, 2024
change/@fluentui-react-slider-63d1fa27-2328-4748-adc2-343d4e4f38c6.json
Outdated
Show resolved
Hide resolved
dmytrokirpa
force-pushed
the
feat/adjust-slider-thumb-position
branch
from
a0ff80e
to
8cde52c
Compare
Hotell
reviewed
Sep 10, 2024
packages/react-components/react-slider/library/src/components/Slider/useSliderStyles.styles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-slider/library/src/components/Slider/useSliderStyles.styles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-slider/library/src/components/Slider/useSliderState.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-slider/library/src/components/Slider/useSliderState.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-slider/library/src/components/Slider/useSliderState.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-slider/library/src/components/Slider/useSliderState.tsx
Outdated
Show resolved
Hide resolved
...act-components/react-slider/library/src/components/Slider/__snapshots__/Slider.test.tsx.snap
Outdated
Show resolved
Hide resolved
Hotell
reviewed
Sep 11, 2024
packages/react-components/react-slider/library/src/components/Slider/useSliderStyles.styles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-slider/library/src/components/Slider/useSliderStyles.styles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-slider/library/src/components/Slider/useSliderState.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-slider/library/src/components/Slider/useSliderState.tsx
Outdated
Show resolved
Hide resolved
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
dmytrokirpa
force-pushed
the
feat/adjust-slider-thumb-position
branch
from
c124f4f
to
e3c304f
Compare
dmytrokirpa
requested review from
micahgodbolt and
a team
and removed request for
a team and
micahgodbolt
tudorpopams
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The thumb's center aligns with the start and end of the track, extending beyond the slider's boundaries.
Screen.Recording.2024-08-30.at.15.45.27.mov
New Behavior
Figma: https://www.figma.com/design/IBCBJxEbPKS7CvLHG55Wn9/branch/tHJGD8KouIEA4AZlZqjoya/Slider?m=auto&node-id=1639-10825&t=ZVseeBNM7o5IqZGg-1
The thumb remains entirely within the confines of the track at all times. When the value is set to either 0% or 100%, the distance between the edge of the track and the center of the thumb equals the radius of the inner thumb.
Screen.Recording.2024-08-30.at.13.22.11.mov
Related Issue(s)