-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(slider-v9): adjust slider design #31989
base: master
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
This design was very intentional. The center of the thumb was supposed to start/end at the beginning/end of the slider. Its worth asking design if they want to re-evaluate this design, but we can't merge this without design being on board and doing the work to update our spec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the request here, but this code is now how we'd fix this....adding 18% would not scale, and it'd be better to remove the code that pushes the thumb out onto the edge of the slider.
I see, this really was the simplest way imaginable. |
@micahgodbolt How would you prefer us to continue here? Wait for a design response? |
Hello @DevJoaoLopes, thank you for your contribution. There is an issue related to the slider improvements (#32171), and it appears that the solution proposed in this PR may not align with the design specifications. Please feel free to reach out if you have any questions. |
Hi @dmytrokirpa , agree... how can we proceed? Has the problem already been resolved? Will there be any adjustments to the component design? |
The main objective was to solve the problem, but if we have another way of solving it, we can close this PR. No problem 😃 |
Previous Behavior
In the slider component, when entering values less than 10 or greater than 90 (thinking of a slider with min 0 and max 100), we get the impression of values 0 or 100, as shown in the image:
New Behavior
Adjusted height (for vertical slider) and width (for horizontal slider)
Related Issue(s)