Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slider-v9): adjust slider design #31989

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

DevJoaoLopes
Copy link

Previous Behavior

In the slider component, when entering values ​​less than 10 or greater than 90 (thinking of a slider with min 0 and max 100), we get the impression of values ​​0 or 100, as shown in the image:

image

New Behavior

Adjusted height (for vertical slider) and width (for horizontal slider)

image

image

Related Issue(s)

@DevJoaoLopes DevJoaoLopes requested review from micahgodbolt and a team as code owners July 12, 2024 21:00
@DevJoaoLopes DevJoaoLopes changed the title Fix slider design fix(slider-v9): adjust slider design Jul 12, 2024
@DevJoaoLopes
Copy link
Author

@DevJoaoLopes please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@micahgodbolt
Copy link
Member

This design was very intentional. The center of the thumb was supposed to start/end at the beginning/end of the slider. Its worth asking design if they want to re-evaluate this design, but we can't merge this without design being on board and doing the work to update our spec.

Copy link
Member

@micahgodbolt micahgodbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the request here, but this code is now how we'd fix this....adding 18% would not scale, and it'd be better to remove the code that pushes the thumb out onto the edge of the slider.

@DevJoaoLopes
Copy link
Author

I understand the request here, but this code is now how we'd fix this....adding 18% would not scale, and it'd be better to remove the code that pushes the thumb out onto the edge of the slider.

I see, this really was the simplest way imaginable.

@DevJoaoLopes
Copy link
Author

@micahgodbolt How would you prefer us to continue here? Wait for a design response?

@dmytrokirpa
Copy link
Contributor

Hello @DevJoaoLopes, thank you for your contribution. There is an issue related to the slider improvements (#32171), and it appears that the solution proposed in this PR may not align with the design specifications.

Please feel free to reach out if you have any questions.

@dmytrokirpa dmytrokirpa added Resolution: Soft Close Soft closing inactive issues over a certain period and removed Needs: Attention labels Aug 9, 2024
@DevJoaoLopes
Copy link
Author

Hi @dmytrokirpa , agree... how can we proceed? Has the problem already been resolved? Will there be any adjustments to the component design?

@DevJoaoLopes
Copy link
Author

The main objective was to solve the problem, but if we have another way of solving it, we can close this PR. No problem 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Slider design needs an update when the value is set to 10 or 90
3 participants