Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value font-weight inside heatmap chart #24726

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Fix value font-weight inside heatmap chart #24726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86eaa6c
fix value font-weight inside heatmap chart
krkshitij Sep 8, 2022
89e15cc
add change file
krkshitij Sep 8, 2022
e2f4db1
fix import
krkshitij Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-charting-bb27a991-70f3-49c3-9940-6ff73c090c66.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fix value font-weight inside heatmap chart",
"packageName": "@fluentui/react-charting",
"email": "[email protected]",
"dependentChangeType": "patch"
}
2 changes: 2 additions & 0 deletions packages/react-charting/src/components/HeatMapChart/HeatMapChart.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { FontWeights } from '@fluentui/react/lib/Styling';
import { IHeatMapChartStyleProps, IHeatMapChartStyles } from './HeatMapChart.types';

export const getHeatMapChartStyles = (props: IHeatMapChartStyleProps): IHeatMapChartStyles => {
Expand All @@ -9,6 +10,7 @@ export const getHeatMapChartStyles = (props: IHeatMapChartStyleProps): IHeatMapC
{
pointerEvents: 'none',
fill: theme.palette.white,
fontWeight: FontWeights.semibold,
},
],
subComponentStyles: {
Expand Down
20 changes: 10 additions & 10 deletions packages/react-charting/src/components/HeatMapChart/__snapshots__/HeatMapChart.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ exports[`HeatMapChart snapShot testing renders HeatMapChart correctly 1`] = `
fill: #ffffff;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
font-weight: 600;
pointer-events: none;
}
dominantBaseline="middle"
Expand Down Expand Up @@ -153,7 +153,7 @@ exports[`HeatMapChart snapShot testing renders HeatMapChart correctly 1`] = `
fill: #ffffff;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
font-weight: 600;
pointer-events: none;
}
dominantBaseline="middle"
Expand Down Expand Up @@ -447,7 +447,7 @@ exports[`HeatMapChart snapShot testing renders corretly even when data is not pr
fill: #ffffff;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
font-weight: 600;
pointer-events: none;
}
dominantBaseline="middle"
Expand Down Expand Up @@ -480,7 +480,7 @@ exports[`HeatMapChart snapShot testing renders corretly even when data is not pr
fill: #ffffff;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
font-weight: 600;
pointer-events: none;
}
dominantBaseline="middle"
Expand Down Expand Up @@ -864,7 +864,7 @@ exports[`HeatMapChart snapShot testing renders hideLegend correctly 1`] = `
fill: #ffffff;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
font-weight: 600;
pointer-events: none;
}
dominantBaseline="middle"
Expand Down Expand Up @@ -897,7 +897,7 @@ exports[`HeatMapChart snapShot testing renders hideLegend correctly 1`] = `
fill: #ffffff;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
font-weight: 600;
pointer-events: none;
}
dominantBaseline="middle"
Expand Down Expand Up @@ -1032,7 +1032,7 @@ exports[`HeatMapChart snapShot testing renders hideTooltip correctly 1`] = `
fill: #ffffff;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
font-weight: 600;
pointer-events: none;
}
dominantBaseline="middle"
Expand Down Expand Up @@ -1065,7 +1065,7 @@ exports[`HeatMapChart snapShot testing renders hideTooltip correctly 1`] = `
fill: #ffffff;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
font-weight: 600;
pointer-events: none;
}
dominantBaseline="middle"
Expand Down Expand Up @@ -1359,7 +1359,7 @@ exports[`HeatMapChart snapShot testing renders yAxisTickFormat correctly 1`] = `
fill: #ffffff;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
font-weight: 600;
pointer-events: none;
}
dominantBaseline="middle"
Expand Down Expand Up @@ -1392,7 +1392,7 @@ exports[`HeatMapChart snapShot testing renders yAxisTickFormat correctly 1`] = `
fill: #ffffff;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
font-weight: 600;
pointer-events: none;
}
dominantBaseline="middle"
Expand Down