Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value font-weight inside heatmap chart #24726

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

krkshitij
Copy link
Contributor

@krkshitij krkshitij commented Sep 8, 2022

Current Behavior

Heatmap chart data values in less contrasted boxes don't pass accessibility

Before

New Behavior

Heatmap chart displays values in semi-bold to help less contrasted boxes

After

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against dd504116164f53a88c14ba932dc8d8e3f561e2b3

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e2f4db1:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 8, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: dd504116164f53a88c14ba932dc8d8e3f561e2b3 (build)

@krkshitij krkshitij marked this pull request as ready for review September 9, 2022 10:13
@krkshitij krkshitij requested a review from a team as a code owner September 9, 2022 10:13
@AtishayMsft AtishayMsft enabled auto-merge (squash) September 14, 2022 16:09
@AtishayMsft AtishayMsft merged commit eea4860 into microsoft:master Sep 14, 2022
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 14, 2022
* master: (28 commits)
  Fix value font-weight inside heatmap chart (microsoft#24726)
  Fix legend overflow-indication-text role (microsoft#24756)
  Support custom locale in date axis  (microsoft#24753)
  Cleanup env variables (microsoft#24739)
  ci(github): add GH Action to add issue labels based on new GH issue template (microsoft#24788)
  Update disallowedChangeTypes for newly created packages, to allow only 'prerelease' change types by default (microsoft#24763)
  feat(react-components): Adding missing AvatarGroup exports (microsoft#24770)
  remove unnecessary nohoist (microsoft#24760)
  feat(react-dialog): supports 1st rule of ARIA (microsoft#24525)
  BREAKING: TableCell layouts are handled by layout components (microsoft#24762)
  feat: Implement table cell layout components (microsoft#24773)
  applying package updates
  fix: remove readonly from DetailsList (microsoft#24615)
  chore: Cleaning up tokens in Button components so they better adhere to the design spec (microsoft#24732)
  fix: react-combobox listbox popup width matches trigger width (microsoft#24733)
  fix: react-combobox Option focus outline only shows with keyboard nav (microsoft#24700)
  feat: Publish react-field package, and export from react-components/unstable (microsoft#24235)
  fix: Replacing bottom border styles with text decoration underline in Link (microsoft#24734)
  docs(react-theme): Update readme (microsoft#24755)
  Add tests for hover states (microsoft#24390)
  ...
@krkshitij krkshitij deleted the bug-accessibility branch September 15, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants