-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-spinner: Use shared tokens #22949
react-spinner: Use shared tokens #22949
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a7ffb05:
|
📊 Bundle size report
Unchanged fixtures
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 933 | 942 | 5000 | |
Button | mount | 564 | 554 | 5000 | |
FluentProvider | mount | 1769 | 1785 | 5000 | |
FluentProviderWithTheme | mount | 266 | 317 | 10 | |
FluentProviderWithTheme | virtual-rerender | 252 | 215 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 275 | 305 | 10 | |
MakeStyles | mount | 1561 | 1494 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d1112b254407f0f0c27119326ec86d2112bc6d70 (build) |
Screener is showing a bunch of differences, are they intentional? |
I will let Geoff answer this, but I think the new screenshots are correct. Subtitle 1 and Subtitle 2 which are used with |
Yes -the bolder weights at those sizes are in the spinner figma. |
* Updated to use tokens were possible * yarn change
Changes
Issues
Updates #22231