Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-spinner: Use shared tokens #22949

Merged
merged 2 commits into from
May 12, 2022

Conversation

GeoffCoxMSFT
Copy link
Member

Changes

  • Updated to use stroke width tokens
  • Updated to use typography tokens

Issues

Updates #22231

@GeoffCoxMSFT GeoffCoxMSFT requested a review from a team as a code owner May 11, 2022 21:55
@GeoffCoxMSFT GeoffCoxMSFT self-assigned this May 11, 2022
@GeoffCoxMSFT GeoffCoxMSFT requested a review from tomi-msft as a code owner May 11, 2022 21:55
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a7ffb05:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-spinner
Spinner
17.321 kB
5.88 kB
17.782 kB
5.943 kB
461 B
63 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
179.701 kB
50.147 kB
react-components
react-components: FluentProvider & webLightTheme
34.066 kB
11.089 kB
🤖 This report was generated against d1112b254407f0f0c27119326ec86d2112bc6d70

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 933 942 5000
Button mount 564 554 5000
FluentProvider mount 1769 1785 5000
FluentProviderWithTheme mount 266 317 10
FluentProviderWithTheme virtual-rerender 252 215 10
FluentProviderWithTheme virtual-rerender-with-unmount 275 305 10
MakeStyles mount 1561 1494 50000

@size-auditor
Copy link

size-auditor bot commented May 11, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d1112b254407f0f0c27119326ec86d2112bc6d70 (build)

@khmakoto
Copy link
Member

Screener is showing a bunch of differences, are they intentional?

@miroslavstastny
Copy link
Member

Screener is showing a bunch of differences, are they intentional?

I will let Geoff answer this, but I think the new screenshots are correct. Subtitle 1 and Subtitle 2 which are used with size="medium" and bigger should be semibold but font-weight was not set at all before this PR.

@GeoffCoxMSFT GeoffCoxMSFT requested a review from khmakoto May 12, 2022 17:38
@GeoffCoxMSFT
Copy link
Member Author

Screener is showing a bunch of differences, are they intentional?

I will let Geoff answer this, but I think the new screenshots are correct. Subtitle 1 and Subtitle 2 which are used with size="medium" and bigger should be semibold but font-weight was not set at all before this PR.

Yes -the bolder weights at those sizes are in the spinner figma.

@GeoffCoxMSFT GeoffCoxMSFT merged commit 06e13fd into microsoft:master May 12, 2022
marwan38 pushed a commit to marwan38/fluentui that referenced this pull request Jun 13, 2022
* Updated to use tokens were possible

* yarn change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants