-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v9 shared form control styles: Input, Select, Combobox, Textarea #22231
Comments
Also SpinButton :) |
Focus indicator stylesFor reference, we talked about having these possibilities in a sync:
|
FYI - I'll use this issue for PRs to add the spacing, duration, and curve tokens as well as the contentsize constants, but won't close the issue. |
@sopranopillow - We already have the shared tokens being used. Coastal consensus is that trying to share this now is a bit early given that the hooks composition model doesn't have style sharing (yet), other libraries take a base-component composition approach, and it is unclear where this shared style would live. Pls close this if you agree. |
Ref: https://github.com/microsoft/fluentui/pull/21068/files#r829433773
We have a number of shared styles and shared style constants (e.g. padding, animation timing, etc.) across Input, Select, Combobox, and Textarea. It would make sense to share those styles somewhere centralized, but we'd need to figure out where.
Existing considerations:
react-tabster
in Textarea: Adding implementation #22096. I think this is worth revisiting, since while it does centralize the shared focus style, it also bakes a lot of very theme-specific styles into react-tabster, even with the passed-in options.react-text
package, but are not exported (see Select vNext styles #21068 (comment) for more context)The text was updated successfully, but these errors were encountered: